Re: [PATCH] Make a warning for -Werror=wrong-language (PR driver/91172).

2019-07-21 Thread Jeff Law
arning_name.  */ >> +    warning (0, "command-line error argument %qs is not valid for %s", >> + text, bad_lang); >> >> It might be better phrased as something like >> >>   "%<-Werror=%> argument %qs is not valid for %s" >

Re: [PATCH] Make a warning for -Werror=wrong-language (PR driver/91172).

2019-07-17 Thread Martin Liška
ot valid for %s" > > The argument is not one of a "command-line error."  It's one > to the -Werror option (which can be specified in other places > besides the command line). I like language corrections from native speakers. I'm sending updated version of the p

Re: [PATCH] Make a warning for -Werror=wrong-language (PR driver/91172).

2019-07-16 Thread Martin Sebor
On 7/16/19 5:16 AM, Martin Liška wrote: Hi. I noticed in the PR that -Werror=argument argument is not verified that the option is supported by a language we compile for. That's changed in the patch. However, it's not ideal as I need to mark the -Werror as the problematic option and one can't pri

[PATCH] Make a warning for -Werror=wrong-language (PR driver/91172).

2019-07-16 Thread Martin Liška
Hi. I noticed in the PR that -Werror=argument argument is not verified that the option is supported by a language we compile for. That's changed in the patch. However, it's not ideal as I need to mark the -Werror as the problematic option and one can't print a proper list of valid languages for wh