Re: [PATCH] MIPS/GCC: Mark text contents as code or data

2018-04-09 Thread Maciej W. Rozycki
Hi Paul, Apologies for the delay in reply, my @imgtec.com address has since become defunct and I have only come across your e-mail in my ever-lagging routine mailing traffic review. On Wed, 14 Mar 2018, Paul Hua wrote: > I noticed that data-sym-pool.c fails on -O0 flags. > > -O0 output : > -

Re: [PATCH] MIPS/GCC: Mark text contents as code or data

2018-03-14 Thread Paul Hua
I noticed that data-sym-pool.c fails on -O0 flags. -O0 output : -cut-- frob: .frame $17,8,$31 # vars= 0, regs= 1/0, args= 0, gp= 0 .mask 0x0002,0 .fmask 0x,0 addiu $sp,-8 sd $17,0($sp)

RE: [PATCH] MIPS/GCC: Mark text contents as code or data

2016-11-16 Thread Maciej W. Rozycki
On Tue, 15 Nov 2016, Matthew Fortune wrote: > I'm a little concerned the expected output tests may be fragile over > time but let's wait and see. Indeed, but I'd rather see false negatives than false positives or no coverage at all. And I hope the pieces of expected assembly quoted will help

RE: [PATCH] MIPS/GCC: Mark text contents as code or data

2016-11-15 Thread Matthew Fortune
Maciej Rozycki writes: > gcc/ > * config/mips/mips-protos.h (mips_set_text_contents_type): New > prototype. > * config/mips/mips.h (ASM_OUTPUT_BEFORE_CASE_LABEL): New macro. > (ASM_OUTPUT_CASE_END): Likewise. > * config/mips/mips.c (mips_set_text_contents_type):

[PATCH] MIPS/GCC: Mark text contents as code or data

2016-11-11 Thread Maciej W. Rozycki
Add local symbols of the correct type at the beginning and the end of inline jump tables and MIPS16 constant pools, marking these data areas as such while keeping code outside marked as such as well. Consider the following example, built as MIPS16 code: $ cat switch16.c int foo (int i) { stati