[PATCH] LTO: get_section: add new argument

2020-10-29 Thread Martin Liška
One more backport I've just tested: gcc/ChangeLog: PR lto/97508 * langhooks.c (lhd_begin_section): Call get_section with not_existing = true. * output.h (get_section): Add new argument. * varasm.c (get_section): Fail when NOT_EXISTING is true and a

Re: [PATCH] LTO: get_section: add new argument

2020-10-29 Thread Martin Liška
On 10/29/20 1:51 PM, Jan Hubicka wrote: From 33c58cab6bc0d779b11e7ffb36bfb485d73d6816 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Wed, 21 Oct 2020 11:11:03 +0200 Subject: [PATCH] LTO: get_section: add new argument gcc/ChangeLog: PR lto/97508 * langhooks.c

Re: [PATCH] LTO: get_section: add new argument

2020-10-29 Thread Jan Hubicka
> From 33c58cab6bc0d779b11e7ffb36bfb485d73d6816 Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Wed, 21 Oct 2020 11:11:03 +0200 > Subject: [PATCH] LTO: get_section: add new argument > > gcc/ChangeLog: > > PR lto/97508 > * langhooks.c (lhd_begin

Re: [PATCH] LTO: get_section: add new argument

2020-10-27 Thread Martin Liška
On 10/22/20 2:14 PM, Martin Liška wrote: On 10/22/20 1:42 PM, Martin Jambor wrote: ...is that I think this should be internal_error.  I am not sure what difference it makes in practice, if any, though. You are right, using internal_error is a better approach. Martin Is also the rest of the

Re: [PATCH] LTO: get_section: add new argument

2020-10-22 Thread Martin Liška
:00 2001 From: Martin Liska Date: Wed, 21 Oct 2020 11:11:03 +0200 Subject: [PATCH] LTO: get_section: add new argument gcc/ChangeLog: PR lto/97508 * langhooks.c (lhd_begin_section): Call get_section with not_existing = true. * output.h (get_section): Add new argument. * varasm.c (get_sect

Re: [PATCH] LTO: get_section: add new argument

2020-10-22 Thread Martin Jambor
n Sep 17 00:00:00 2001 > From: Martin Liska > Date: Wed, 21 Oct 2020 11:11:03 +0200 > Subject: [PATCH] LTO: get_section: add new argument > > gcc/ChangeLog: > > PR lto/97508 > * langhooks.c (lhd_begin_section): Call get_section with > not_existing =

Re: [PATCH] LTO: get_section: add new argument

2020-10-22 Thread Martin Liška
Subject: [PATCH] LTO: get_section: add new argument gcc/ChangeLog: PR lto/97508 * langhooks.c (lhd_begin_section): Call get_section with not_existing = true. * output.h (get_section): Add new argument. * varasm.c (get_section): Fail when NOT_EXISTING is true and a section already exists. *

Re: [PATCH] LTO: get_section: add new argument

2020-10-21 Thread Martin Liška
dding missing patch. Martin >From 8c765ebad21da7f34a5038b4df8c4d29fb391055 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Wed, 21 Oct 2020 11:11:03 +0200 Subject: [PATCH] LTO: get_section: add new argument gcc/ChangeLog: PR lto/97508 * langhooks.c (lhd_begin_section): Call get_section w

Re: [PATCH] LTO: get_section: add new argument

2020-10-21 Thread Martin Liška
On 10/21/20 12:06 PM, Jan Hubicka wrote: I think the streaming should happen only from ipa-fnsummary. Oriignally ipa-prop was ipa-cp only, then indirect inlining was added, but these days we have specialized analysis pass and thus ipa-prop should be intergrated to it. All right, there's a WIP p

Re: [PATCH] LTO: get_section: add new argument

2020-10-21 Thread Jan Hubicka
> Hey. > > During partial linking we ipa_prop_write_jump_functions twice from 2 IPA > pass (fnsummary and cp). That produces 2 compressed blocks in an ELF section > and then zstd complains as sections size does not correspond to the compressed > stream. > > I'm adding both sanity check changes an

[PATCH] LTO: get_section: add new argument

2020-10-21 Thread Martin Liška
Hey. During partial linking we ipa_prop_write_jump_functions twice from 2 IPA pass (fnsummary and cp). That produces 2 compressed blocks in an ELF section and then zstd complains as sections size does not correspond to the compressed stream. I'm adding both sanity check changes and the fix in ip