Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-11-04 Thread Jeff Law
On 11/01/13 19:42, Vladimir Makarov wrote: I did not expected from the patch any problems too. It is so obvious. This simple change should not affect x86 (or any other target currently using LRA). The code in question is used only for x86-64 and only for modern intel processing tuning. It is

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-11-01 Thread Vladimir Makarov
On 11/1/2013, 3:45 PM, Jeff Law wrote: On 10/31/13 14:03, Robert Suchanek wrote: Hi David, No, I do not have read/write SVN access. I know a person who could commit the patch for me, however, if you can commit it, I'd be grateful. Note, I didn't see anywhere in this thread an indication this t

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-11-01 Thread David Edelsohn
On Fri, Nov 1, 2013 at 6:00 PM, Jeff Law wrote: > I'm not in a rush to revert... I don't plan on doing anything on the trunk > over the weekend. I'm comfortable waiting until Monday, both to see if > anyone else trips over whatever is going wrong and to give Robert or anyone > else time to debu

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-11-01 Thread Mike Stump
On Nov 1, 2013, at 12:45 PM, Jeff Law wrote: > Vlad, when approving patches, please make sure they've been through the usual > bootstrap and regression testing procedures. I usually place the blame on the person committing it, as they broke it. :-)

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-11-01 Thread Jeff Law
On 11/01/13 14:39, David Edelsohn wrote: On Fri, Nov 1, 2013 at 3:45 PM, Jeff Law wrote: On 10/31/13 14:03, Robert Suchanek wrote: Hi David, No, I do not have read/write SVN access. I know a person who could commit the patch for me, however, if you can commit it, I'd be grateful. Note, I d

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-11-01 Thread David Edelsohn
On Fri, Nov 1, 2013 at 3:45 PM, Jeff Law wrote: > On 10/31/13 14:03, Robert Suchanek wrote: >> >> Hi David, >> >> No, I do not have read/write SVN access. I know a person who could commit >> the patch for me, however, if you can commit it, I'd be grateful. > > Note, I didn't see anywhere in this t

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-11-01 Thread Jeff Law
On 10/31/13 14:03, Robert Suchanek wrote: Hi David, No, I do not have read/write SVN access. I know a person who could commit the patch for me, however, if you can commit it, I'd be grateful. Note, I didn't see anywhere in this thread an indication this test had been through a bootstrap and re

RE: [PATCH] LRA: Fix incorrect register spill/reload

2013-10-31 Thread Robert Suchanek
Hi David, No, I do not have read/write SVN access. I know a person who could commit the patch for me, however, if you can commit it, I'd be grateful. Regards, Robert > Vladimir Makarov wrote: > Robert, thanks for finding it and informing. You can commit the patch > into the trunk. Rober

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-10-31 Thread David Edelsohn
> Vladimir Makarov wrote: > Robert, thanks for finding it and informing. You can commit the patch > into the trunk. Robert, Do you have GCC SVN access? If not, please ask one of us to commit your patch for you. Thanks, David

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-10-31 Thread Vladimir Makarov
On 10/31/2013 09:23 AM, Robert Suchanek wrote: > Hello, > > When investigating regression with LRA enabled for mips16 I found incorrect > spilling and reload of > registers by callee. In the case, one register was not saved, although used, > and another one never > used but saved/restored. > >

[PATCH] LRA: Fix incorrect register spill/reload

2013-10-31 Thread Robert Suchanek
Hello, When investigating regression with LRA enabled for mips16 I found incorrect spilling and reload of registers by callee.  In the case, one register was not saved, although used, and another one never used but saved/restored. The issue appears to be in setting registers ever lived and sub