Re: [PATCH] Instance information in DWARF discriminators

2012-12-05 Thread Thomas Quinot
* Tom Tromey, 2012-11-29 : > Thomas> Now, an alternative might be to have an array of instance IDs stored > at > Thomas> the struct line_maps level, with the same indices at the set of > ordinary > Thomas> maps, which would be allocated only when flag_debug_instances is used; > Thomas> when it i

Re: [PATCH] Instance information in DWARF discriminators

2012-11-29 Thread Tom Tromey
> "Thomas" == Thomas Quinot writes: Thomas> As for the size impact on line_map_ordinary, indeed that's an additional Thomas> int here, but I'm not sure we allocate so many objects of that kind that Thomas> the increase is significant. Could you please measure it? My guess is that it is worse

Re: [PATCH] Instance information in DWARF discriminators

2012-11-29 Thread Thomas Quinot
* Richard Biener, 2012-11-28 : > You need to stream the id with LTO, no? Also increasing the size > of line_map_ordinary might not be the most welcom change ... Thanks for your feedback Richard, I'll take care of adding the missing LTO pieces, and improve documentation of the flag. As for the s

Re: [PATCH] Instance information in DWARF discriminators

2012-11-28 Thread Richard Biener
On Wed, Nov 28, 2012 at 4:46 PM, Thomas Quinot wrote: > The following proposed change adds a new mode of operation where > the discriminator field in DWARF debugging information is set from > information provided by a language front-end to discriminate > between distinct code instances coming from

[PATCH] Instance information in DWARF discriminators

2012-11-28 Thread Thomas Quinot
The following proposed change adds a new mode of operation where the discriminator field in DWARF debugging information is set from information provided by a language front-end to discriminate between distinct code instances coming from instances of a given template. (Currently the discriminator is