Re: [PATCH] Improvements to -freorder-blocks-and-partition support

2013-05-15 Thread Teresa Johnson
On Tue, May 14, 2013 at 11:04 PM, Jeff Law wrote: > On 05/15/2013 12:02 AM, Steven Bosscher wrote: >> >> On Wed, May 15, 2013 at 12:50 AM, Teresa Johnson wrote: >>> >>> On Tue, May 14, 2013 at 2:49 PM, Steven Bosscher wrote: One nit: Can you keep the verify_hot_cold_block_grouping functi

Re: [PATCH] Improvements to -freorder-blocks-and-partition support

2013-05-14 Thread Jeff Law
On 05/15/2013 12:02 AM, Steven Bosscher wrote: On Wed, May 15, 2013 at 12:50 AM, Teresa Johnson wrote: On Tue, May 14, 2013 at 2:49 PM, Steven Bosscher wrote: One nit: Can you keep the verify_hot_cold_block_grouping function separate? rtl_verify_flow_info* is already too big and complex (somewh

Re: [PATCH] Improvements to -freorder-blocks-and-partition support

2013-05-14 Thread Steven Bosscher
On Wed, May 15, 2013 at 12:50 AM, Teresa Johnson wrote: > On Tue, May 14, 2013 at 2:49 PM, Steven Bosscher wrote: >> One nit: Can you keep the verify_hot_cold_block_grouping function >> separate? rtl_verify_flow_info* is already too big and complex >> (somewhere down on my TODO list is splitting it

Re: [PATCH] Improvements to -freorder-blocks-and-partition support

2013-05-14 Thread Jeff Law
On 05/14/2013 03:42 PM, Teresa Johnson wrote: Patch 1 of 3 split out from the patch I sent last week that fixes problems with -freorder-blocks-and-partition, with some additional verification improvements. See http://gcc.gnu.org/ml/gcc-patches/2013-05/threads.html#00388 for context. This patch

Re: [PATCH] Improvements to -freorder-blocks-and-partition support

2013-05-14 Thread Teresa Johnson
On Tue, May 14, 2013 at 2:49 PM, Steven Bosscher wrote: > On Tue, May 14, 2013 at 11:42 PM, Teresa Johnson wrote: >> >> * function.h (has_bb_partition): New rtl_data flag. >> (bb_reorder_complete): Ditto. >> * cfgrtl.c (rtl_verify_flow_info_1): After bbro, verify >>

Re: [PATCH] Improvements to -freorder-blocks-and-partition support

2013-05-14 Thread Steven Bosscher
On Tue, May 14, 2013 at 11:42 PM, Teresa Johnson wrote: > > * function.h (has_bb_partition): New rtl_data flag. > (bb_reorder_complete): Ditto. > * cfgrtl.c (rtl_verify_flow_info_1): After bbro, verify > that text sections switch at most once in layout order. >

[PATCH] Improvements to -freorder-blocks-and-partition support

2013-05-14 Thread Teresa Johnson
Patch 1 of 3 split out from the patch I sent last week that fixes problems with -freorder-blocks-and-partition, with some additional verification improvements. See http://gcc.gnu.org/ml/gcc-patches/2013-05/threads.html#00388 for context. This patch adds a flag to the rtl_data structure to indicat