Re: [PATCH] Improve stack_protect_test_ on x86 (PR target/90568)

2019-05-23 Thread Uros Bizjak
On Thu, May 23, 2019 at 12:41 AM Jakub Jelinek wrote: > > Hi! > > For stack_protect_test_[sd]i we don't use comparison, so that we clear the > content of the register and don't keep the stack canary in any register for > security reasons, but as mentioned in the PR, using sub instead of xor > achi

[PATCH] Improve stack_protect_test_ on x86 (PR target/90568)

2019-05-22 Thread Jakub Jelinek
Hi! For stack_protect_test_[sd]i we don't use comparison, so that we clear the content of the register and don't keep the stack canary in any register for security reasons, but as mentioned in the PR, using sub instead of xor achieves the same effect in the likely case (no failure), in the failure