Re: [PATCH] Improve dump files for SRA early candidate check

2011-06-23 Thread Richard Guenther
On Thu, Jun 23, 2011 at 8:07 AM, Eric Botcazou wrote: >> +         if (!host_integerp (DECL_FIELD_OFFSET (fld), 1)) >> +           { >> +             *msg = "structure field offset not host integer"; /* ??? */ >> +             return true; >> +           } > > Offsets can be variable, like sizes,

Re: [PATCH] Improve dump files for SRA early candidate check

2011-06-22 Thread Eric Botcazou
> + if (!host_integerp (DECL_FIELD_OFFSET (fld), 1)) > + { > + *msg = "structure field offset not host integer"; /* ??? */ > + return true; > + } Offsets can be variable, like sizes, in Ada for example. >if (TYPE_VOLATILE (et)) > - r

[PATCH] Improve dump files for SRA early candidate check

2011-06-22 Thread Andi Kleen
From: Andi Kleen I wanted to figure out why some structures of mine don't get SRAed. Unfortunately the dump files were not very helpful because the variables got rejected early without any comments. This patch reports the actual reasons in the dump file. Passes test suite on x86-64 linux. Ok to