Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-08 Thread H.J. Lu
On Fri, Oct 5, 2012 at 7:19 AM, Jakub Jelinek wrote: > On Fri, Oct 05, 2012 at 03:59:55PM +0200, Richard Guenther wrote: >> I don't think we want to rely on that ... so just keep the push/pop_cfun. > > Ok, so this is what I'm retesting (basically just comments added and the two > lines (subcode an

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Jakub Jelinek
On Fri, Oct 05, 2012 at 03:59:55PM +0200, Richard Guenther wrote: > I don't think we want to rely on that ... so just keep the push/pop_cfun. Ok, so this is what I'm retesting (basically just comments added and the two lines (subcode and set) swapped: 2012-10-05 Jakub Jelinek PR debug

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Richard Guenther
On Fri, Oct 5, 2012 at 2:49 PM, Jakub Jelinek wrote: > On Fri, Oct 05, 2012 at 02:20:13PM +0200, Richard Guenther wrote: >> The following could use a comment on what you are doing ... > > Will add something. > >> > + if (args_to_skip) >> > +for (parm = DECL_ARGUMENTS (current_function_decl),

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Jakub Jelinek
On Fri, Oct 05, 2012 at 02:49:07PM +0200, Jakub Jelinek wrote: > I believe that gsi_insert_before in another function > isn't going to work well. > E.g. update_modified_stmt starts with > if (!ssa_operands_active (cfun)) > return; > > Or is it ok to use gsi_insert_before_without_update and e

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Jakub Jelinek
On Fri, Oct 05, 2012 at 02:20:13PM +0200, Richard Guenther wrote: > The following could use a comment on what you are doing ... Will add something. > > + if (args_to_skip) > > +for (parm = DECL_ARGUMENTS (current_function_decl), num = 0; > > +parm; parm = DECL_CHAIN (parm), num++) > > +

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-05 Thread Richard Guenther
On Wed, 3 Oct 2012, Jakub Jelinek wrote: > On Tue, Sep 11, 2012 at 03:59:56PM +0200, Jakub Jelinek wrote: > > As discussed in the PR, right now we do a very bad job for debug info > > of partially inlined functions (both when they are kept only partially > > inlined, or when partial inlining is pe

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-04 Thread Jakub Jelinek
On Thu, Oct 04, 2012 at 01:31:08AM -0300, Alexandre Oliva wrote: > On Oct 3, 2012, Jakub Jelinek wrote: > > > basically there is a non-addressable parameter in stack slot, and > > vt_canon_true_dep -> canon_true_dependence thinks an argument push > > insn might alias with it, because it doesn't

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-03 Thread Alexandre Oliva
On Oct 3, 2012, Jakub Jelinek wrote: > basically there is a non-addressable parameter in stack slot, and > vt_canon_true_dep -> canon_true_dependence thinks an argument push > insn might alias with it, because it doesn't have a MEM_EXPR and > ao_ref_from_mem fails. I have a pending (still unrev

[PATCH] Improve debug info for partial inlining (PR debug/54519, take 2)

2012-10-03 Thread Jakub Jelinek
On Tue, Sep 11, 2012 at 03:59:56PM +0200, Jakub Jelinek wrote: > As discussed in the PR, right now we do a very bad job for debug info > of partially inlined functions (both when they are kept only partially > inlined, or when partial inlining is performed, but doesn't seem to be > useful and foo.p

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519)

2012-09-11 Thread Jakub Jelinek
On Tue, Sep 11, 2012 at 04:41:24PM +0200, Steven Bosscher wrote: > > + if (args_to_skip) > > +for (parm = DECL_ARGUMENTS (current_function_decl), num = 0; > > +parm; parm = DECL_CHAIN (parm), num++) > > + if (bitmap_bit_p (args_to_skip, num) > > + && is_gimple_reg (parm))

Re: [PATCH] Improve debug info for partial inlining (PR debug/54519)

2012-09-11 Thread Steven Bosscher
> + if (args_to_skip) > +for (parm = DECL_ARGUMENTS (current_function_decl), num = 0; > +parm; parm = DECL_CHAIN (parm), num++) > + if (bitmap_bit_p (args_to_skip, num) > + && is_gimple_reg (parm)) > + { > + tree ddecl; > + gimple def_temp; > + > +

[PATCH] Improve debug info for partial inlining (PR debug/54519)

2012-09-11 Thread Jakub Jelinek
Hi! As discussed in the PR, right now we do a very bad job for debug info of partially inlined functions (both when they are kept only partially inlined, or when partial inlining is performed, but doesn't seem to be useful and foo.part.N is inlined back, either into the original function, or into