Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-20 Thread Tom Tromey
> "Ramana" == Ramana Radhakrishnan writes: Ramana> Otherwise looks ok to me . Sergio was asked me to ping this for him, but instead I re-read the entire thread and I think that this was an approval conditional on him making the request changes (just to ChangeLog), which he did. So, I am che

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-14 Thread Sergio Durigan Junior
Sergio Durigan Junior writes: > Sergio Durigan Junior writes: > >> Bernd Schmidt writes: >> >>> On 12/01/11 13:01, Ramana Radhakrishnan wrote: Sergio: Other than a few minor tweaks to the Changelog it largely looks obvious to me. Bernd, could you take another look at this s

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-08 Thread Sergio Durigan Junior
Sergio Durigan Junior writes: > Bernd Schmidt writes: > >> On 12/01/11 13:01, Ramana Radhakrishnan wrote: >>> Sergio: Other than a few minor tweaks to the Changelog it largely >>> looks obvious to me. >>> >>> Bernd, could you take another look at this since this is now shared >>> with the c6x b

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-02 Thread Richard Henderson
On 12/02/2011 04:25 AM, Bernd Schmidt wrote: > Doesn't look like it would cause problems. I have no idea what > builtin_frob_return_addr does but it appears to exist everywhere. It's for adjusting the return address in magic ways. E.g. Sparc pc+8 for structure returns, ARM low bit for thumb retu

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-02 Thread Sergio Durigan Junior
Ramana Radhakrishnan writes: > Sergio: Other than a few minor tweaks to the Changelog it largely > looks obvious to me. Hello Ramana, Thanks for the review. Here is the updated version of the patch. I asked Tom Tromey to commit it for me, since I don't have write permission on the repository.

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-02 Thread Sergio Durigan Junior
Bernd Schmidt writes: > On 12/01/11 13:01, Ramana Radhakrishnan wrote: >> Sergio: Other than a few minor tweaks to the Changelog it largely >> looks obvious to me. >> >> Bernd, could you take another look at this since this is now shared >> with the c6x backend ? > > Doesn't look like it would c

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-02 Thread Bernd Schmidt
On 12/01/11 13:01, Ramana Radhakrishnan wrote: > Sergio: Other than a few minor tweaks to the Changelog it largely > looks obvious to me. > > Bernd, could you take another look at this since this is now shared > with the c6x backend ? Doesn't look like it would cause problems. I have no idea what

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-01 Thread Ramana Radhakrishnan
Sergio: Other than a few minor tweaks to the Changelog it largely looks obvious to me. Bernd, could you take another look at this since this is now shared with the c6x backend ? > Thanks, > > Sergio. > > diff --git a/libgcc/ChangeLog b/libgcc/ChangeLog > index 305e8ad..f6e9dec 100644 > --- a/libg

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-11-30 Thread Sergio Durigan Junior
Sergio Durigan Junior writes: > Hello, > > This is the implementation of > for the ARM > unwinder. Since ARM has a different unwinder, I basically replicated > the existing code (on unwind-dw2.c) into it, with a few modifications in > ord

[PATCH] Implement stap probe on ARM's unwinder

2011-11-22 Thread Sergio Durigan Junior
Hello, This is the implementation of for the ARM unwinder. Since ARM has a different unwinder, I basically replicated the existing code (on unwind-dw2.c) into it, with a few modifications in order to gather the necessary information for th