Re: [PATCH] Implement POINTER_DIFF_EXPR entry in range-op.

2021-09-03 Thread Aldy Hernandez via Gcc-patches
Patches welcome :-). On Fri, Sep 3, 2021, 18:42 Martin Sebor wrote: > On 9/3/21 8:41 AM, Aldy Hernandez via Gcc-patches wrote: > > [Andrew, do you see any problem with using the minus relational code > > here? It seems like everything matches up.] > > > > I've seen cases in the upcoming jump th

Re: [PATCH] Implement POINTER_DIFF_EXPR entry in range-op.

2021-09-03 Thread Martin Sebor via Gcc-patches
On 9/3/21 8:41 AM, Aldy Hernandez via Gcc-patches wrote: [Andrew, do you see any problem with using the minus relational code here? It seems like everything matches up.] I've seen cases in the upcoming jump threader enhancements where we see a difference of two pointers that are known to be equ

Re: [PATCH] Implement POINTER_DIFF_EXPR entry in range-op.

2021-09-03 Thread Aldy Hernandez via Gcc-patches
On 9/3/21 5:41 PM, Jakub Jelinek wrote: On Fri, Sep 03, 2021 at 09:09:59AM -0600, Jeff Law via Gcc-patches wrote: On 9/3/2021 9:05 AM, Andrew MacLeod via Gcc-patches wrote: On 9/3/21 10:41 AM, Aldy Hernandez wrote: [Andrew, do you see any problem with using the minus relational code here?

Re: [PATCH] Implement POINTER_DIFF_EXPR entry in range-op.

2021-09-03 Thread Jakub Jelinek via Gcc-patches
On Fri, Sep 03, 2021 at 09:09:59AM -0600, Jeff Law via Gcc-patches wrote: > > > On 9/3/2021 9:05 AM, Andrew MacLeod via Gcc-patches wrote: > > On 9/3/21 10:41 AM, Aldy Hernandez wrote: > > > [Andrew, do you see any problem with using the minus relational code > > > here?  It seems like everything

Re: [PATCH] Implement POINTER_DIFF_EXPR entry in range-op.

2021-09-03 Thread Aldy Hernandez via Gcc-patches
On 9/3/21 5:05 PM, Andrew MacLeod wrote: On 9/3/21 10:41 AM, Aldy Hernandez wrote: [Andrew, do you see any problem with using the minus relational code here?  It seems like everything matches up.] I've seen cases in the upcoming jump threader enhancements where we see a difference of two poi

Re: [PATCH] Implement POINTER_DIFF_EXPR entry in range-op.

2021-09-03 Thread Jeff Law via Gcc-patches
On 9/3/2021 9:05 AM, Andrew MacLeod via Gcc-patches wrote: On 9/3/21 10:41 AM, Aldy Hernandez wrote: [Andrew, do you see any problem with using the minus relational code here?  It seems like everything matches up.] I've seen cases in the upcoming jump threader enhancements where we see a dif

Re: [PATCH] Implement POINTER_DIFF_EXPR entry in range-op.

2021-09-03 Thread Andrew MacLeod via Gcc-patches
On 9/3/21 10:41 AM, Aldy Hernandez wrote: [Andrew, do you see any problem with using the minus relational code here? It seems like everything matches up.] I've seen cases in the upcoming jump threader enhancements where we see a difference of two pointers that are known to be equivalent, and ye

[PATCH] Implement POINTER_DIFF_EXPR entry in range-op.

2021-09-03 Thread Aldy Hernandez via Gcc-patches
[Andrew, do you see any problem with using the minus relational code here? It seems like everything matches up.] I've seen cases in the upcoming jump threader enhancements where we see a difference of two pointers that are known to be equivalent, and yet we fail to return 0 for the range. This i