Re: [PATCH] IPA ICF + ASAN: do not merge vars with different alignment

2021-02-23 Thread Martin Liška
On 2/23/21 3:55 PM, Richard Biener wrote: On Tue, Feb 23, 2021 at 3:41 PM Martin Liška wrote: On 2/23/21 3:32 PM, Richard Biener wrote: On Tue, Feb 23, 2021 at 3:22 PM Martin Liška wrote: On 2/23/21 12:56 PM, Richard Biener wrote: Can't we fix the asan runtime? Does the same issue happen

Re: [PATCH] IPA ICF + ASAN: do not merge vars with different alignment

2021-02-23 Thread Richard Biener via Gcc-patches
On Tue, Feb 23, 2021 at 3:41 PM Martin Liška wrote: > > On 2/23/21 3:32 PM, Richard Biener wrote: > > On Tue, Feb 23, 2021 at 3:22 PM Martin Liška wrote: > >> > >> On 2/23/21 12:56 PM, Richard Biener wrote: > >>> Can't we fix the asan runtime? Does the same issue happen when merging > >>> two co

Re: [PATCH] IPA ICF + ASAN: do not merge vars with different alignment

2021-02-23 Thread Martin Liška
On 2/23/21 3:32 PM, Richard Biener wrote: On Tue, Feb 23, 2021 at 3:22 PM Martin Liška wrote: On 2/23/21 12:56 PM, Richard Biener wrote: Can't we fix the asan runtime? Does the same issue happen when merging two comdat with different alignment and LTO? All right, there's a detail explanati

Re: [PATCH] IPA ICF + ASAN: do not merge vars with different alignment

2021-02-23 Thread Richard Biener via Gcc-patches
On Tue, Feb 23, 2021 at 3:22 PM Martin Liška wrote: > > On 2/23/21 12:56 PM, Richard Biener wrote: > > Can't we fix the asan runtime? Does the same issue happen when merging > > two comdat with different alignment and LTO? > > All right, there's a detail explanation what happens. > Let's consider

Re: [PATCH] IPA ICF + ASAN: do not merge vars with different alignment

2021-02-23 Thread Martin Liška
On 2/23/21 12:56 PM, Richard Biener wrote: Can't we fix the asan runtime? Does the same issue happen when merging two comdat with different alignment and LTO? All right, there's a detail explanation what happens. Let's consider the following example: struct my_struct { unsigned long volatil

Re: [PATCH] IPA ICF + ASAN: do not merge vars with different alignment

2021-02-23 Thread Richard Biener via Gcc-patches
On Tue, Feb 23, 2021 at 10:42 AM Martin Liška wrote: > > Hello. > > The patch is about confusion that brings ICF when it merged 2 variables > with different alignments (when ASAN is used). > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Can't

[PATCH] IPA ICF + ASAN: do not merge vars with different alignment

2021-02-23 Thread Martin Liška
Hello. The patch is about confusion that brings ICF when it merged 2 variables with different alignments (when ASAN is used). Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: PR sanitizer/99168 * ipa-ic