Re: [PATCH] ICF: move readonly decision for variables to the right place

2015-03-06 Thread Jan Hubicka
> > This caused: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65334 This is another alias issue exposed by ICF. Vectorizer attempts to increase an alignment of alias by modifying its DECL_ALIGN, but it doesnot really achieve it - when outputting the definition we use DECL_ALIGN of the ult

Re: [PATCH] ICF: move readonly decision for variables to the right place

2015-03-06 Thread H.J. Lu
On Sun, Mar 1, 2015 at 11:53 PM, Jan Hubicka wrote: > Hi, > this is a variant of patch I commited. > It takes care to load the constructor to memory in sem_variable::equals > and donot touch it earlier. I also made sem_variable::parse to skip volatile > and reigster variables. > > Bootstrapped/re

Re: [PATCH] ICF: move readonly decision for variables to the right place

2015-03-02 Thread Martin Liška
On 03/02/2015 08:53 AM, Jan Hubicka wrote: Hi, this is a variant of patch I commited. It takes care to load the constructor to memory in sem_variable::equals and donot touch it earlier. I also made sem_variable::parse to skip volatile and reigster variables. Bootstrapped/regtested x86_64-linux,

Re: [PATCH] ICF: move readonly decision for variables to the right place

2015-03-01 Thread Jan Hubicka
Hi, this is a variant of patch I commited. It takes care to load the constructor to memory in sem_variable::equals and donot touch it earlier. I also made sem_variable::parse to skip volatile and reigster variables. Bootstrapped/regtested x86_64-linux, lto-bootstrapped with -fmerge-all-constants

Re: [PATCH] ICF: move readonly decision for variables to the right place

2015-03-01 Thread Jan Hubicka
Hi, my comments to your patch was not complete. ipa-icf is quite confused about how to get the constructor. This is how it works: In during in_lto_p DECL_INITIAL may be set to error_mark_node and once you really want to have the constructor there is varpool_node->get_constuctor method. Because in

Re: [PATCH] ICF: move readonly decision for variables to the right place

2015-02-28 Thread Jan Hubicka
> diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c > index 864a5d0..5b1fcff 100644 > --- a/gcc/ipa-icf.c > +++ b/gcc/ipa-icf.c > @@ -1410,10 +1410,6 @@ sem_variable::parse (varpool_node *node, > bitmap_obstack *stack) >if (node->alias) > return NULL; > > - bool readonly = TYPE_P (decl) ? TYP

[PATCH] ICF: move readonly decision for variables to the right place

2015-02-28 Thread Martin Liška
Hello. This patch makes correctly decision about variables that are read-only and are candidates for merge operation. Tested on x86_64-unknown-linux-gnu. Ready for trunk? Thanks, Martin >From 72370368eb04a69bf36b42f692d44c21592bc94a Mon Sep 17 00:00:00 2001 From: mliska Date: Fri, 27 Feb 2015 2