Re: [PATCH] Handle not explicitly zero terminated strings in merge sections

2018-08-17 Thread Bernd Edlinger
Hi, this is an update of the patch, which has just two Ada test cases added for string merging which are based on Olivier's suggested test case. Note that except the "Check STRING_CSTs in varasm.c" patch series, there is now another patch needed to work around issues with 71625: [PATCH] Call bra

Re: [PATCH] Handle not explicitly zero terminated strings in merge sections

2018-08-07 Thread Bernd Edlinger
Hi, I realized that the previous version did not handle zero terminated Ada constants correctly as in $ cat hello.adb procedure Hello is procedure puts (S : String) with Import, Convention => C; X : String(1..8) := "abcdefg" & Ascii.Nul; begin puts ("1234" & Ascii.Nul ); puts (X);

Re: [PATCH] Handle not explicitly zero terminated strings in merge sections

2018-08-04 Thread Bernd Edlinger
Aehm, I forgot the Fortran FE patch which is also a pre-condition (at least for building with all languages): [PATCH] Create internally nul terminated string literals in fortan FE https://gcc.gnu.org/ml/fortran/2018-08/msg0.html Thanks Bernd. On 08/04/18 17:44, Bernd Edlinger wrote: > Agai

Re: [PATCH] Handle not explicitly zero terminated strings in merge sections

2018-08-04 Thread Bernd Edlinger
Again, with patch On 08/04/18 17:43, Bernd Edlinger wrote: > Hi! > > > This patch is inspired by Olivier's feedback to my previous patch on the > zero-termination of Ada STRING_CST. > > The idea is that strings that do not have embedded nul characters _and_ > do not happen to be zero-termin

[PATCH] Handle not explicitly zero terminated strings in merge sections

2018-08-04 Thread Bernd Edlinger
Hi! This patch is inspired by Olivier's feedback to my previous patch on the zero-termination of Ada STRING_CST. The idea is that strings that do not have embedded nul characters _and_ do not happen to be zero-terminated in the DECL_UNIT_SIZE, are currently not in the merge string sections. To