Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-28 Thread Yury Gribov
> The above hunk is not needed anymore, is it? Right. > Ok for trunk without that hunk (and with Makefile.in regenerated again). Done, r205482. -Y

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-28 Thread Jakub Jelinek
On Thu, Nov 28, 2013 at 03:29:02PM +0400, Yury Gribov wrote: > > I wonder if this can't be done through > > just adding -fno-rtti to AM_CXXFLAGS and say > > ubsan_handlers_cxx.% ubsan_type_hash.% : AM_CXXFLAGS += -frtti > > Yup, that did the trick. Attaching modified patch. > @@ -13,11 +13,13 @@

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-28 Thread Yury Gribov
> I wonder if this can't be done through > just adding -fno-rtti to AM_CXXFLAGS and say > ubsan_handlers_cxx.% ubsan_type_hash.% : AM_CXXFLAGS += -frtti Yup, that did the trick. Attaching modified patch. diff --git a/libsanitizer/ubsan/Makefile.am b/libsanitizer/ubsan/Makefile.am index e98984a..

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-28 Thread Jakub Jelinek
On Wed, Nov 27, 2013 at 12:01:50PM +0400, Yury Gribov wrote: > As discussed in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59106 > only a subset of libubsan should be built with RTTI support. > Attached patch adds custom build rules for relevant files. We assume GNU make I think, I wonder if this

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-27 Thread Yury Gribov
> Wasn't that already checked in? No, that's an addition to previous commit. -Y

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-27 Thread Jeff Law
On 11/27/13 01:01, Yury Gribov wrote: Hi all, As discussed in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59106 only a subset of libubsan should be built with RTTI support. Attached patch adds custom build rules for relevant files. Wasn't that already checked in? commit 5e0d610a433356af747fded

[PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-27 Thread Yury Gribov
Hi all, As discussed in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59106 only a subset of libubsan should be built with RTTI support. Attached patch adds custom build rules for relevant files. -Y diff --git a/libsanitizer/ubsan/Makefile.am b/libsanitizer/ubsan/Makefile.am index e98984a..eaab