Re: [PATCH] Further C lapack workaround tweaks

2019-05-30 Thread Marek Polacek
On Thu, May 30, 2019 at 07:26:28AM -0400, Marek Polacek wrote: > On Thu, May 30, 2019 at 11:37:35AM +0200, Jakub Jelinek wrote: > > Hi! > > > > On Wed, May 29, 2019 at 06:41:57PM -0700, Jerry DeLisle wrote: > > > Just a typo: > > > > > > > +Disallow tail call optimization when a calling routine m

Re: [PATCH] Further C lapack workaround tweaks

2019-05-30 Thread Marek Polacek
On Thu, May 30, 2019 at 11:37:35AM +0200, Jakub Jelinek wrote: > Hi! > > On Wed, May 29, 2019 at 06:41:57PM -0700, Jerry DeLisle wrote: > > Just a typo: > > > > > +Disallow tail call optimization when a calling routine may have omitted > > character lenghts. > > > > s/lenghts/lengths There's al

Re: [PATCH] Further C lapack workaround tweaks

2019-05-30 Thread Jakub Jelinek
Hi! On Wed, May 29, 2019 at 06:41:57PM -0700, Jerry DeLisle wrote: > Just a typo: > > > +Disallow tail call optimization when a calling routine may have omitted > character lenghts. > > s/lenghts/lengths Thanks. Found similar typo in tree-predcom.c (and in old ChangeLog entries that I'm not go

Re: [PATCH] Further C lapack workaround tweaks

2019-05-29 Thread Jakub Jelinek
On Wed, May 29, 2019 at 04:02:55PM +0200, Thomas Koenig wrote: > > As I said earlier in the PR, I don't like -fbroken-callers option much, > > as the option name doesn't hint what it is doing at all. > > > > The following patch renames the option and makes it into a 3 state option, > > with the de

Re: [PATCH] Further C lapack workaround tweaks

2019-05-29 Thread Thomas Koenig
Hi Jakub, As I said earlier in the PR, I don't like -fbroken-callers option much, as the option name doesn't hint what it is doing at all. The following patch renames the option and makes it into a 3 state option, with the default being a middle-ground, where it avoids the tail calls in functio

[PATCH] Further C lapack workaround tweaks

2019-05-29 Thread Jakub Jelinek
Hi! As I said earlier in the PR, I don't like -fbroken-callers option much, as the option name doesn't hint what it is doing at all. The following patch renames the option and makes it into a 3 state option, with the default being a middle-ground, where it avoids the tail calls in functions that