Re: [PATCH] Function Multiversioning Bug, checking for function versions

2013-01-02 Thread Sriraman Tallam
On Wed, Jan 2, 2013 at 1:01 PM, Jakub Jelinek wrote: > On Wed, Jan 02, 2013 at 12:23:45PM -0800, Sriraman Tallam wrote: >> --- config/i386/i386.c (revision 194817) >> +++ config/i386/i386.c (working copy) >> @@ -29290,7 +29290,7 @@ ix86_get_function_versions_dispatcher (void *decl) >> >>/* S

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2013-01-02 Thread Sriraman Tallam
On Wed, Jan 2, 2013 at 1:01 PM, Jakub Jelinek wrote: > On Wed, Jan 02, 2013 at 12:23:45PM -0800, Sriraman Tallam wrote: >> --- config/i386/i386.c (revision 194817) >> +++ config/i386/i386.c (working copy) >> @@ -29290,7 +29290,7 @@ ix86_get_function_versions_dispatcher (void *decl) >> >>/* S

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2013-01-02 Thread Jakub Jelinek
On Wed, Jan 02, 2013 at 12:23:45PM -0800, Sriraman Tallam wrote: > --- config/i386/i386.c (revision 194817) > +++ config/i386/i386.c (working copy) > @@ -29290,7 +29290,7 @@ ix86_get_function_versions_dispatcher (void *decl) > >/* Set the dispatcher for all the versions. */ >it_v = defa

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2013-01-02 Thread Sriraman Tallam
I committed this trivial patch to fix some corner case bugs in Function Multiversioning. * config/i386/i386.c (ix86_get_function_versions_dispatcher): Fix bug in loop predicate. (fold_builtin_cpu): Do not share cpu model decls across statements. Index: config/i386/i386.c =

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-27 Thread Alexander Ivchenko
I'm sorry - I didn't notice that it works only for c++ frontend. It works for me now! thanks, Alexander 2012/12/27 Sriraman Tallam : > On Thu, Dec 27, 2012 at 2:05 AM, Andreas Schwab wrote: >> diff --git a/gcc/ChangeLog b/gcc/ChangeLog >> index 148388d..575e03a 100644 >> --- a/gcc/ChangeLog >> +

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-27 Thread Sriraman Tallam
On Thu, Dec 27, 2012 at 2:05 AM, Andreas Schwab wrote: > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index 148388d..575e03a 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,4 +1,7 @@ > -<<< .mine > +2012-12-27 Andreas Schwab > + > + * target.def (supports_function_versions)

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-27 Thread Andreas Schwab
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 148388d..575e03a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,4 +1,7 @@ -<<< .mine +2012-12-27 Andreas Schwab + + * target.def (supports_function_versions): Fix typo. + 2012-12-26 Sriraman Tallam * doc/tm.texi.in (T

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-26 Thread Sriraman Tallam
I committed this patch with the fix. Thanks, -Sri. On Tue, Dec 18, 2012 at 4:13 PM, Diego Novillo wrote: > On Tue, Dec 18, 2012 at 6:38 PM, Sriraman Tallam wrote: > >> The function versions are now determined purely based on the string >> value and not on DECL_FUNCTION_SPECIFIC_TARGET fields. S

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-18 Thread Diego Novillo
On Tue, Dec 18, 2012 at 6:38 PM, Sriraman Tallam wrote: > The function versions are now determined purely based on the string > value and not on DECL_FUNCTION_SPECIFIC_TARGET fields. So, this check > is not necessary. Ah, OK. Thanks. The patch is OK with that minor fix then. Diego.

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-18 Thread Sriraman Tallam
Hi Diego, Thanks for the review. On Tue, Dec 18, 2012 at 8:04 AM, Diego Novillo wrote: > On 2012-11-16 14:55 , Sriraman Tallam wrote: >> >> Hi, >> >> The previous patch was incomplete because the front-end strips off >> invalid target attributes which I did not consider. The attached >> u

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-12-18 Thread Diego Novillo
On 2012-11-16 14:55 , Sriraman Tallam wrote: Hi, The previous patch was incomplete because the front-end strips off invalid target attributes which I did not consider. The attached updated patch handles this with updated test cases. Thanks, -Sri. On Thu, Nov 15, 2012 at 2:08 PM, Sriraman T

Re: [PATCH] Function Multiversioning Bug, checking for function versions

2012-11-16 Thread Sriraman Tallam
Hi, The previous patch was incomplete because the front-end strips off invalid target attributes which I did not consider. The attached updated patch handles this with updated test cases. Thanks, -Sri. On Thu, Nov 15, 2012 at 2:08 PM, Sriraman Tallam wrote: > Hi, > >Currently, function m

[PATCH] Function Multiversioning Bug, checking for function versions

2012-11-15 Thread Sriraman Tallam
Hi, Currently, function multiversioning determines that two functions are different by comparing the arch type and isa flags that are set after the target string is processed. This leads to cases where the versions become identical when the command-line target options are altered. For example