Re: [PATCH] Free dominance info at the beginning of pass_jump_after_combine

2019-11-19 Thread Segher Boessenkool
On Wed, Nov 13, 2019 at 01:15:18PM +0100, Ilya Leoshkevich wrote: > > But OTOH it may well be the case that other things in cleanup_cfg make > > the known dominance info invalid as well, in which case just the comment > > is a bit misleading. Sounds likely to me :-) > > Yeah, that's what I worry

Re: [PATCH] Free dominance info at the beginning of pass_jump_after_combine

2019-11-13 Thread Ilya Leoshkevich
> On Tue, Nov 12, 2019 at 04:32:36PM +0100, Ilya Leoshkevich wrote: >>> Am 12.11.2019 um 15:32 schrieb Segher Boessenkool >>> : >>> On Tue, Nov 12, 2019 at 03:11:05PM +0100, Ilya Leoshkevich wrote: unsigned int pass_jump_after_combine::execute (function *) { + /* Jump threadin

Re: [PATCH] Free dominance info at the beginning of pass_jump_after_combine

2019-11-13 Thread Segher Boessenkool
Hi! On Tue, Nov 12, 2019 at 04:32:36PM +0100, Ilya Leoshkevich wrote: > > Am 12.11.2019 um 15:32 schrieb Segher Boessenkool > > : > > On Tue, Nov 12, 2019 at 03:11:05PM +0100, Ilya Leoshkevich wrote: > >> unsigned int > >> pass_jump_after_combine::execute (function *) > >> { > >> + /* Jump threa

Re: [PATCH] Free dominance info at the beginning of pass_jump_after_combine

2019-11-12 Thread Ilya Leoshkevich
> Am 12.11.2019 um 15:32 schrieb Segher Boessenkool > : > > Hi! > > On Tue, Nov 12, 2019 at 03:11:05PM +0100, Ilya Leoshkevich wrote: >> try_forward_edges does not update dominance info, and merge_blocks >> relies on it being up-to-date. In PR92430 stale dominance info makes >> merge_blocks pro

Re: [PATCH] Free dominance info at the beginning of pass_jump_after_combine

2019-11-12 Thread Segher Boessenkool
Hi! On Tue, Nov 12, 2019 at 03:11:05PM +0100, Ilya Leoshkevich wrote: > try_forward_edges does not update dominance info, and merge_blocks > relies on it being up-to-date. In PR92430 stale dominance info makes > merge_blocks produce a loop in the dominator tree, which in turn makes > delete_basic

Re: [PATCH] Free dominance info at the beginning of pass_jump_after_combine

2019-11-12 Thread Richard Biener
On Tue, 12 Nov 2019, Ilya Leoshkevich wrote: > Bootstrapped and regtested on x86_64-redhat-linux, s390x-redhat-linux > and ppc64le-redhat-linux. OK for trunk and gcc-9-branch? > > try_forward_edges does not update dominance info, and merge_blocks > relies on it being up-to-date. In PR92430 stal

[PATCH] Free dominance info at the beginning of pass_jump_after_combine

2019-11-12 Thread Ilya Leoshkevich
Bootstrapped and regtested on x86_64-redhat-linux, s390x-redhat-linux and ppc64le-redhat-linux. OK for trunk and gcc-9-branch? try_forward_edges does not update dominance info, and merge_blocks relies on it being up-to-date. In PR92430 stale dominance info makes merge_blocks produce a loop in th