Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2019-07-09 Thread Gerald Pfeifer
On Sat, 19 Jan 2019, Jakub Jelinek wrote: >> how about the refinement below? > LGTM. Thanks. The context has changed a bit since then (due to links being added), so I had to manually re-apply the patch and committed the following now. Gerald Index: changes.html =

Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2019-01-19 Thread Jakub Jelinek
On Sat, Jan 19, 2019 at 11:49:34PM +0100, Gerald Pfeifer wrote: > Hej Jakub, hej Fortran hackers, > > On Wed, 21 Nov 2018, Jakub Jelinek wrote: > > Like this? Ok for trunk/wwwdocs? > > > > 2018-11-21 Jakub Jelinek > > > > * invoke.texi (-fdec-include): Document. > > how about the refine

Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2019-01-19 Thread Gerald Pfeifer
Hej Jakub, hej Fortran hackers, On Wed, 21 Nov 2018, Jakub Jelinek wrote: > Like this? Ok for trunk/wwwdocs? > > 2018-11-21 Jakub Jelinek > > * invoke.texi (-fdec-include): Document. how about the refinement below? Gerald Index: gcc-9/changes.html ===

Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2018-11-21 Thread Thomas Koenig
Hi Jakub, Before 9.0 is released, we should also document the flag (and the extension it supports) in the manual, and note it in changes.html and on the Wiki. Would you also do that? Like this? Ok for trunk/wwwdocs? OK for trunk (and I don't think you need my OK for wwwdocs, but you have it

Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2018-11-21 Thread Jakub Jelinek
On Wed, Nov 21, 2018 at 08:31:17AM +0100, Thomas Koenig wrote: > > I'd like to ping this patch, ok for trunk? > > OK. Thanks for the patch! Thanks. > Before 9.0 is released, we should also document the flag > (and the extension it supports) in the manual, and note it > in changes.html and on the

Re: Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2018-11-20 Thread Thomas Koenig
Hi Jakub, I'd like to ping this patch, ok for trunk? OK. Thanks for the patch! Before 9.0 is released, we should also document the flag (and the extension it supports) in the manual, and note it in changes.html and on the Wiki. Would you also do that? Regards Thomas

Patch ping (Re: [PATCH] Fortran include line fixes and -fdec-include support)

2018-11-20 Thread Jakub Jelinek
Hi! I'd like to ping this patch, ok for trunk? > 2018-11-12 Jakub Jelinek > Mark Eggleston > > * lang.opt (fdec-include): New option. > * options.c (set_dec_flags): Set also flag_dec_include. > * scanner.c (include_line): Change return type from bool to int. >

Re: [PATCH] Fortran include line fixes and -fdec-include support

2018-11-13 Thread Jakub Jelinek
On Tue, Nov 13, 2018 at 10:06:39AM +, Mark Eggleston wrote: > I've applied this patch and tried it out. > > The following fail to compile: That is IMHO correct, it fails to compile with ifort as well: https://fortran.godbolt.org/z/Aav6dv The problem is in mixing quotes, " vs. ' If I fix that

Re: [PATCH] Fortran include line fixes and -fdec-include support

2018-11-13 Thread Mark Eggleston
Jakub, I've applied this patch and tried it out. The following fail to compile: In free form with or without the optional initial & on the continuation line: subroutine one()   include &   &"include_4.inc'   integer(i4) :: i end subroutine one In fixed form:   subroutine one()   in

Re: [PATCH] Fortran include line fixes and -fdec-include support

2018-11-12 Thread Fritz Reese
On Mon, Nov 12, 2018 at 9:51 AM Jakub Jelinek wrote: > > In fortran97.pdf I read: > "Except in a character context, blanks are insignificant and may be used > freely throughout the program." > and while we handle that in most cases, we don't allow spaces in INCLUDE > lines in fixed form, while e.

[PATCH] Fortran include line fixes and -fdec-include support

2018-11-12 Thread Jakub Jelinek
Hi! In fortran97.pdf I read: "Except in a character context, blanks are insignificant and may be used freely throughout the program." and while we handle that in most cases, we don't allow spaces in INCLUDE lines in fixed form, while e.g. ifort does. Another thing, which I haven't touched in the