Re: [PATCH] Fortran : ICE in build_field PR95614 (2nd attempt)

2020-10-13 Thread Paul Richard Thomas via Gcc-patches
usive scope is its defining > >subprogram (19.3.3)." > > > > I've added two new test cases for subroutine and function. > > > > I'm not certain about the restriction that the external procedure > > should be a generic name. I have found the ear

Re: [PATCH] Fortran : ICE in build_field PR95614 (2nd attempt)

2020-10-13 Thread Mark Eggleston
7;m not certain about the restriction that the external procedure should be a generic name. I have found the earlier standards somewhat confusing on the subject, so I haven't determined whether there should be any standards dependent code. [PATCH] Fortran  :  ICE in build_field PR95614 Local iden

[PATCH] Fortran : ICE in build_field PR95614 (2nd attempt)

2020-09-29 Thread Mark Eggleston
1 Jun 2020 14:33:51 +0100 Subject: [PATCH] Fortran : ICE in build_field PR95614 Local identifiers can not be the same as a module name. Original patch by Steve Kargl resulted in name clashes between common block names and local identifiers. A local identifier can be the same as a global ide

Re: *PING* Re: [PATCH] Fortran : ICE in build_field PR95614

2020-09-24 Thread Thomas König
Hi Mark, I haven't yet committed this. I am unfamiliar with Andre, I've checked MAINTAINERS and I find Andre in the "Write after approval" section. Is Andre's approval sufficient? If so MAINTAINERS needs to be updated. The official list of people who can review is at https://gcc.gnu.org/

*PING* Re: [PATCH] Fortran : ICE in build_field PR95614

2020-09-24 Thread Mark Eggleston
al identifier is a common block name. The change to the patch is: if (gsym && gsym->type != GSYM_UNKNOWN && gsym->type != GSYM_COMMON) instead of: if (gsym && gsym->type != GSYM_UNKNOWN) Tested on x86_64 using make -j 8 check-fortran. OK to commit? [PATCH] For

Re: [PATCH] Fortran : ICE in build_field PR95614

2020-09-14 Thread Andre Vehreschild
e global identifier is a common block name. > > The change to the patch is: > > if (gsym && gsym->type != GSYM_UNKNOWN && gsym->type != GSYM_COMMON) > > instead of: > > if (gsym && gsym->type != GSYM_UNKNOWN) > > Tested on x86_64 using

Re: [PATCH] Fortran : ICE in build_field PR95614

2020-09-14 Thread Mark Eggleston
MMON) instead of: if (gsym && gsym->type != GSYM_UNKNOWN) Tested on x86_64 using make -j 8 check-fortran. OK to commit? [PATCH] Fortran  :  ICE in build_field PR95614 Local identifiers can not be the same as a module name. Original patch by Steve Kargl resulted in name clashes bet

[PATCH] Fortran : ICE in build_field PR95614

2020-09-04 Thread Mark Eggleston
= GSYM_UNKNOWN) Tested on x86_64 using make -j 8 check-fortran. OK to commit? [PATCH] Fortran  :  ICE in build_field PR95614 Local identifiers can not be the same as a module name. Original patch by Steve Kargl resulted in name clashes between common block names and local identifiers.  A loca