Re: [PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-30 Thread Bin.Cheng
On Sat, Nov 28, 2015 at 3:40 AM, Jakub Jelinek wrote: > Hi! > > The recent changes where vector sqrt is represented in the IL using > IFN_SQRT instead of target specific builtins broke the discovery > of vector rsqrt, as targetm.builtin_reciprocal is called only > on builtin functions (not interna

Re: [PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-30 Thread Richard Biener
On Mon, 30 Nov 2015, Jakub Jelinek wrote: > On Mon, Nov 30, 2015 at 02:30:04PM +, Richard Sandiford wrote: > > > keep the builtin_reciprocal hook (perhaps renamed to builtin_rsqrt) > > > for the purpose of this condition and nothing else (i.e. return a > > > boolean) and let the rest be determ

Re: [PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-30 Thread Jakub Jelinek
On Mon, Nov 30, 2015 at 02:30:04PM +, Richard Sandiford wrote: > > keep the builtin_reciprocal hook (perhaps renamed to builtin_rsqrt) > > for the purpose of this condition and nothing else (i.e. return a > > boolean) and let the rest be determined from the optab, just commit > > the already po

Re: [PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-30 Thread Richard Sandiford
Jakub Jelinek writes: > On Sat, Nov 28, 2015 at 09:38:40AM +0100, Jakub Jelinek wrote: >> On Sat, Nov 28, 2015 at 08:47:18AM +0100, Richard Biener wrote: >> > On November 27, 2015 8:40:56 PM GMT+01:00, Jakub Jelinek >> > wrote: >> > >The recent changes where vector sqrt is represented in the IL u

Re: [PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-30 Thread Jakub Jelinek
On Sat, Nov 28, 2015 at 09:38:40AM +0100, Jakub Jelinek wrote: > On Sat, Nov 28, 2015 at 08:47:18AM +0100, Richard Biener wrote: > > On November 27, 2015 8:40:56 PM GMT+01:00, Jakub Jelinek > > wrote: > > >The recent changes where vector sqrt is represented in the IL using > > >IFN_SQRT instead o

Re: [PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-28 Thread Richard Biener
On November 28, 2015 9:38:40 AM GMT+01:00, Jakub Jelinek wrote: >On Sat, Nov 28, 2015 at 08:47:18AM +0100, Richard Biener wrote: >> On November 27, 2015 8:40:56 PM GMT+01:00, Jakub Jelinek > wrote: >> >The recent changes where vector sqrt is represented in the IL using >> >IFN_SQRT instead of tar

Re: [PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-28 Thread Jakub Jelinek
On Sat, Nov 28, 2015 at 08:47:18AM +0100, Richard Biener wrote: > On November 27, 2015 8:40:56 PM GMT+01:00, Jakub Jelinek > wrote: > >The recent changes where vector sqrt is represented in the IL using > >IFN_SQRT instead of target specific builtins broke the discovery > >of vector rsqrt, as tar

Re: [PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-27 Thread Richard Biener
On November 27, 2015 8:40:56 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The recent changes where vector sqrt is represented in the IL using >IFN_SQRT instead of target specific builtins broke the discovery >of vector rsqrt, as targetm.builtin_reciprocal is called only >on builtin functions (not i

[PATCH] Fix vector rsqrt discovery (PR tree-optimization/68501)

2015-11-27 Thread Jakub Jelinek
Hi! The recent changes where vector sqrt is represented in the IL using IFN_SQRT instead of target specific builtins broke the discovery of vector rsqrt, as targetm.builtin_reciprocal is called only on builtin functions (not internal functions). Furthermore, for internal fns, not only the IFN_* i