subject:"\[PATCH\] Fix up tm_clone_hasher"

Re: [PATCH] Fix up tm_clone_hasher

2015-04-30 Thread Jeff Law

On 04/30/2015 03:30 AM, Marek Polacek wrote: Ping. On Wed, Apr 22, 2015 at 05:24:43PM +0200, Marek Polacek wrote: handle_cache_entry in tm_clone_hasher looks wrong: the condition if (e != HTAB_EMPTY_ENTRY || e != HTAB_DELETED_ENTRY) is always true. While it could be fixed by just changing || i

Re: [PATCH] Fix up tm_clone_hasher

2015-04-30 Thread Marek Polacek

Ping. On Wed, Apr 22, 2015 at 05:24:43PM +0200, Marek Polacek wrote: > handle_cache_entry in tm_clone_hasher looks wrong: the condition > if (e != HTAB_EMPTY_ENTRY || e != HTAB_DELETED_ENTRY) is always true. While > it could be fixed by just changing || into &&, I decided to follow suit and > do

[PATCH] Fix up tm_clone_hasher

2015-04-22 Thread Marek Polacek

handle_cache_entry in tm_clone_hasher looks wrong: the condition if (e != HTAB_EMPTY_ENTRY || e != HTAB_DELETED_ENTRY) is always true. While it could be fixed by just changing || into &&, I decided to follow suit and do what we do in handle_cache_entry's elsewhere in the codebase. I've fixed a fo