Re: Patch ping: [PATCH] Fix thinko in insert_reciprocals (PR tree-optimization/86835)

2018-08-11 Thread Richard Biener
On August 11, 2018 1:06:59 PM GMT+02:00, Jakub Jelinek wrote: >On Fri, Aug 03, 2018 at 05:59:24PM +0200, Jakub Jelinek wrote: >> 2018-08-03 Jakub Jelinek >> >> PR tree-optimization/86835 >> * tree-ssa-math-opts.c (insert_reciprocals): Even when inserting >> new_stmt after def_gs

Patch ping: [PATCH] Fix thinko in insert_reciprocals (PR tree-optimization/86835)

2018-08-11 Thread Jakub Jelinek
On Fri, Aug 03, 2018 at 05:59:24PM +0200, Jakub Jelinek wrote: > 2018-08-03 Jakub Jelinek > > PR tree-optimization/86835 > * tree-ssa-math-opts.c (insert_reciprocals): Even when inserting > new_stmt after def_gsi, make sure to insert new_square_stmt after > that stmt, no

[PATCH] Fix thinko in insert_reciprocals (PR tree-optimization/86835)

2018-08-03 Thread Jakub Jelinek
Hi! As the comment say, we want to insert (if should_insert_square_recip is true) new_square_stmt right after new_stmt. The current code does that correctly if new_stmt is inserted with gsi_insert_before (&gsi, new_stmt, GSI_SAME_STMT); because the following gsi_insert_before (&gsi, new_squ