Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)

2019-08-07 Thread Steve Ellcey
On Wed, 2019-08-07 at 10:40 +, Szabolcs Nagy wrote: > --- > --- > On 31/07/2019 08:25, Richard Sandiford wrote: > > Steve Ellcey writes: > > > > > > 2019-07-30 Steve Ellcey > > > > > > * omp-simd-clone.c (simd_clone_adjust_return_type): Remove cal

Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)

2019-08-07 Thread Szabolcs Nagy
On 31/07/2019 08:25, Richard Sandiford wrote: > Steve Ellcey writes: >> >> 2019-07-30 Steve Ellcey >> >> * omp-simd-clone.c (simd_clone_adjust_return_type): Remove call to >> build_distinct_type_copy. >> (simd_clone_adjust_argument_types): Ditto. >> (simd_clone_adjust): Call

Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)

2019-07-31 Thread Richard Sandiford
Steve Ellcey writes: > On Tue, 2019-07-30 at 14:31 +0100, Richard Sandiford wrote: >> >> > - >> > - tree new_type = build_distinct_type_copy (TREE_TYPE (node- >> > >decl)); >> > - TYPE_ARG_TYPES (new_type) = new_reversed; >> >> I think you still need this line, just applied to the exis

Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)

2019-07-30 Thread Steve Ellcey
On Tue, 2019-07-30 at 14:31 +0100, Richard Sandiford wrote: > > > - > > - tree new_type = build_distinct_type_copy (TREE_TYPE (node- > > >decl)); > > - TYPE_ARG_TYPES (new_type) = new_reversed; > > I think you still need this line, just applied to the existing type > rather than a new o

Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)

2019-07-30 Thread Richard Sandiford
Steve Ellcey writes: > On Fri, 2019-07-19 at 19:24 +0100, Richard Sandiford wrote: >> >> You can probably also remove: >> >> tree new_type = build_distinct_type_copy (TREE_TYPE (node->decl)); >> ... >> TREE_TYPE (node->decl) = new_type; >> >> in simd_clone_adjust_argument_type

Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)

2019-07-29 Thread Steve Ellcey
Ping. Steve Ellcey sell...@marvell.com On Mon, 2019-07-22 at 11:25 -0700, Steve Ellcey wrote: > On Fri, 2019-07-19 at 19:24 +0100, Richard Sandiford wrote: > > > > You can probably also remove: > > > > tree new_type = build_distinct_type_copy (TREE_TYPE (node- > > >decl)); > > ... >

Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)

2019-07-22 Thread Steve Ellcey
On Fri, 2019-07-19 at 19:24 +0100, Richard Sandiford wrote: > > You can probably also remove: > > tree new_type = build_distinct_type_copy (TREE_TYPE (node->decl)); > ... > TREE_TYPE (node->decl) = new_type; > > in simd_clone_adjust_argument_types. > > I'm happy doing it this

Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)

2019-07-19 Thread Richard Sandiford
Steve Ellcey writes: > Here is version two of my patch to fix simd attribute handling on > aarch64. Unlike the first patch where I swapped the order of the > calls to targetm.simd_clone.adjust and simd_clone_adjust_return_type, > in this one I remove the (conditional) call to build_distinct_type_

Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)

2019-07-19 Thread Steve Ellcey
Here is version two of my patch to fix simd attribute handling on aarch64. Unlike the first patch where I swapped the order of the calls to targetm.simd_clone.adjust and simd_clone_adjust_return_type, in this one I remove the (conditional) call to build_distinct_type_copy from simd_clone_adjust_re