Re: [PATCH] Fix overflows in get_ref_base_and_extent (PR tree-optimization/59779)

2014-03-13 Thread Richard Biener
On March 13, 2014 6:50:53 PM CET, Jakub Jelinek wrote: >Hi! > >The outer-1.c testcase apparently fails on 32-bit HWI targets, the >problem >is that the int x[1][1]; array has bitsize that fits into uhwi, >but >not shwi, so we get negative maxsize that isn't -1. > >After discussions with Ri

Re: [PATCH] Fix overflows in get_ref_base_and_extent (PR tree-optimization/59779)

2014-03-13 Thread Jakub Jelinek
On Thu, Mar 13, 2014 at 02:13:39PM -0400, John David Anglin wrote: > Is this change different from the one attached to PR? I have a > bootstrap/regtest > going with it. Yes, the one attached to the PR had major bugs, in two spots replaced if (maxsize == -1 with if (!maxsize.is_minus_one () ra

Re: [PATCH] Fix overflows in get_ref_base_and_extent (PR tree-optimization/59779)

2014-03-13 Thread John David Anglin
Hi Jakub, Is this change different from the one attached to PR? I have a bootstrap/regtest going with it. Dave On 3/13/2014 1:50 PM, Jakub Jelinek wrote: Hi! The outer-1.c testcase apparently fails on 32-bit HWI targets, the problem is that the int x[1][1]; array has bitsize that f

[PATCH] Fix overflows in get_ref_base_and_extent (PR tree-optimization/59779)

2014-03-13 Thread Jakub Jelinek
Hi! The outer-1.c testcase apparently fails on 32-bit HWI targets, the problem is that the int x[1][1]; array has bitsize that fits into uhwi, but not shwi, so we get negative maxsize that isn't -1. After discussions with Richard on IRC, I've implemented computation of bitsize and maxsize