Re: [PATCH] Fix lots of uninitialized memory uses in sched_analyze_reg

2013-03-05 Thread Jakub Jelinek
On Tue, Mar 05, 2013 at 11:58:09PM -0500, Vladimir Makarov wrote: > I don't see any harm from your patch but I guess it should be fixed > by clearing reg_know_equiv_p. I think you need Steven's opinion on > this as he is an author of the code. Yeah, I've already committed the clearing of the sbit

Re: [PATCH] Fix lots of uninitialized memory uses in sched_analyze_reg

2013-03-05 Thread Vladimir Makarov
On 13-03-04 4:17 PM, Jakub Jelinek wrote: Hi! Something that again hits lots of testcases during valgrind checking bootstrap. init_alias_analysis apparently does vec_safe_grow_cleared (reg_known_value, maxreg - FIRST_PSEUDO_REGISTER); reg_known_equiv_p = sbitmap_alloc (maxreg - FIRST_PSEU

Re: [PATCH] Fix lots of uninitialized memory uses in sched_analyze_reg

2013-03-05 Thread Richard Biener
On Mon, Mar 4, 2013 at 10:17 PM, Jakub Jelinek wrote: > Hi! > > Something that again hits lots of testcases during valgrind checking > bootstrap. init_alias_analysis apparently does > vec_safe_grow_cleared (reg_known_value, maxreg - FIRST_PSEUDO_REGISTER); > reg_known_equiv_p = sbitmap_alloc

[PATCH] Fix lots of uninitialized memory uses in sched_analyze_reg (take 2)

2013-03-04 Thread Jakub Jelinek
On Mon, Mar 04, 2013 at 11:17:41PM +0100, Steven Bosscher wrote: > On Mon, Mar 4, 2013 at 10:17 PM, Jakub Jelinek wrote: > > Something that again hits lots of testcases during valgrind checking > > bootstrap. init_alias_analysis apparently does > > vec_safe_grow_cleared (reg_known_value, maxreg

Re: [PATCH] Fix lots of uninitialized memory uses in sched_analyze_reg

2013-03-04 Thread Steven Bosscher
On Mon, Mar 4, 2013 at 10:17 PM, Jakub Jelinek wrote: > Hi! > > Something that again hits lots of testcases during valgrind checking > bootstrap. init_alias_analysis apparently does > vec_safe_grow_cleared (reg_known_value, maxreg - FIRST_PSEUDO_REGISTER); > reg_known_equiv_p = sbitmap_alloc (

[PATCH] Fix lots of uninitialized memory uses in sched_analyze_reg

2013-03-04 Thread Jakub Jelinek
Hi! Something that again hits lots of testcases during valgrind checking bootstrap. init_alias_analysis apparently does vec_safe_grow_cleared (reg_known_value, maxreg - FIRST_PSEUDO_REGISTER); reg_known_equiv_p = sbitmap_alloc (maxreg - FIRST_PSEUDO_REGISTER); but doesn't bitmap_clear (reg_kn