Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-12 Thread Joseph Myers
On Tue, 12 Mar 2019, Hans-Peter Nilsson wrote: > When is it appropriate to make the user add -latomic to link > their program? Perhaps different answers for fortran and C++. > I'm guessing "always when using any atomic construct" for C. I think we should link with --as-needed -latomic --no-as-ne

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-12 Thread Hans-Peter Nilsson
Regarding this sometimes-add--latomic(-in-testsuite) that is revisited: When is it appropriate to make the user add -latomic to link their program? Perhaps different answers for fortran and C++. I'm guessing "always when using any atomic construct" for C. I had a grep-look in gcc/doc before aski

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-12 Thread John David Anglin
On 2019-03-12 7:05 p.m., Jonathan Wakely wrote: > On 12/03/19 23:01 +, Joseph Myers wrote: >> On Mon, 11 Mar 2019, Jonathan Wakely wrote: >> >>> +proc add_options_for_libatomic { flags } { >>> +    if { [istarget hppa*-*-hpux*] } { >>> +   return "$flags -L../../libatomic/.libs -latomic" >>

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-12 Thread Jonathan Wakely
On 12/03/19 23:01 +, Joseph Myers wrote: On Mon, 11 Mar 2019, Jonathan Wakely wrote: +proc add_options_for_libatomic { flags } { +if { [istarget hppa*-*-hpux*] } { + return "$flags -L../../libatomic/.libs -latomic" +} It's generally inappropriate to hardcode such ../../libat

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-12 Thread Joseph Myers
On Mon, 11 Mar 2019, Jonathan Wakely wrote: > +proc add_options_for_libatomic { flags } { > +if { [istarget hppa*-*-hpux*] } { > + return "$flags -L../../libatomic/.libs -latomic" > +} It's generally inappropriate to hardcode such ../../libatomic/.libs paths without making sure it'

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-11 Thread Jonathan Wakely
On 11/03/19 13:54 +, Jonathan Wakely wrote: On 11/03/19 09:27 -0400, John David Anglin wrote: On 2019-03-11 9:16 a.m., Jonathan Wakely wrote: On 11/03/19 14:13 +0100, Andreas Schwab wrote: On Mär 11 2019, Jonathan Wakely wrote: What do you think about adding the following? --- a/libstd

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-11 Thread Jonathan Wakely
On 11/03/19 09:27 -0400, John David Anglin wrote: On 2019-03-11 9:16 a.m., Jonathan Wakely wrote: On 11/03/19 14:13 +0100, Andreas Schwab wrote: On Mär 11 2019, Jonathan Wakely wrote: What do you think about adding the following? --- a/libstdc++-v3/testsuite/lib/dg-options.exp +++ b/libstdc

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-11 Thread John David Anglin
On 2019-03-11 9:16 a.m., Jonathan Wakely wrote: > On 11/03/19 14:13 +0100, Andreas Schwab wrote: >> On Mär 11 2019, Jonathan Wakely wrote: >> >>> What do you think about adding the following? >>> >>> --- a/libstdc++-v3/testsuite/lib/dg-options.exp >>> +++ b/libstdc++-v3/testsuite/lib/dg-options.ex

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-11 Thread Jonathan Wakely
On 11/03/19 14:13 +0100, Andreas Schwab wrote: On Mär 11 2019, Jonathan Wakely wrote: What do you think about adding the following? --- a/libstdc++-v3/testsuite/lib/dg-options.exp +++ b/libstdc++-v3/testsuite/lib/dg-options.exp @@ -257,6 +257,15 @@ proc add_options_for_net_ts { flags } {

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-11 Thread Andreas Schwab
On Mär 11 2019, Jonathan Wakely wrote: > What do you think about adding the following? > > --- a/libstdc++-v3/testsuite/lib/dg-options.exp > +++ b/libstdc++-v3/testsuite/lib/dg-options.exp > @@ -257,6 +257,15 @@ proc add_options_for_net_ts { flags } { > return $flags > } > > +# Add to FLAGS a

Re: [PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-11 Thread Jonathan Wakely
On 09/03/19 12:46 -0500, John David Anglin wrote: The hppa*-*-hpux* target has no builtin atomic support, so we need to explicitly link applications requiring atomic support against libatomic. Okay? Dave -- John David Anglin dave.ang...@bell.net 2019-03-09 John David Anglin PR li

[PATCH] Fix libstdc++ tests requiring atomic support on hppa-hpux

2019-03-09 Thread John David Anglin
The hppa*-*-hpux* target has no builtin atomic support, so we need to explicitly link applications requiring atomic support against libatomic. Okay? Dave -- John David Anglin dave.ang...@bell.net 2019-03-09 John David Anglin PR libstdc++/89461 * testsuite/20_util/shared_pt