Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-24 Thread Marek Polacek
On Mon, Aug 24, 2015 at 11:07:41AM +0200, Jakub Jelinek wrote: > On Fri, Aug 21, 2015 at 07:22:24PM +0200, Richard Biener wrote: > > Not sure either. Needs to be investigated. BTW, built-in trap is also > > nothrow AFAIR. > > I think the bug is in the Go FE which incorrectly doesn't set > TREE_TH

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-24 Thread Jakub Jelinek
On Fri, Aug 21, 2015 at 07:22:24PM +0200, Richard Biener wrote: > On August 21, 2015 6:42:15 PM GMT+02:00, Marek Polacek > wrote: > >On Fri, Aug 21, 2015 at 06:23:09PM +0200, Richard Biener wrote: > >> >> Yes, but gimple_call_noreturn_p is false on __builtin_trap. > >That's > >> >quite > >> >> c

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On August 21, 2015 6:42:15 PM GMT+02:00, Marek Polacek wrote: >On Fri, Aug 21, 2015 at 06:23:09PM +0200, Richard Biener wrote: >> >> Yes, but gimple_call_noreturn_p is false on __builtin_trap. >That's >> >quite >> >> confusing... but flags_from_decl_or_type really returns 0 for >> >__builtin_tra

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Marek Polacek
On Fri, Aug 21, 2015 at 06:23:09PM +0200, Richard Biener wrote: > >> Yes, but gimple_call_noreturn_p is false on __builtin_trap. That's > >quite > >> confusing... but flags_from_decl_or_type really returns 0 for > >__builtin_trap. > >Well, if that's intentional (and offhand I have no idea if it is

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On August 21, 2015 5:09:46 PM GMT+02:00, Jeff Law wrote: >On 08/21/2015 08:41 AM, Marek Polacek wrote: >> On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: >>> On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek >wrote: On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote:

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On August 21, 2015 5:09:46 PM GMT+02:00, Jeff Law wrote: >On 08/21/2015 08:41 AM, Marek Polacek wrote: >> On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: >>> On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek >wrote: On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote:

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Jeff Law
On 08/21/2015 08:41 AM, Marek Polacek wrote: On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek wrote: On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: This fixe

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Jeff Law
On 08/21/2015 08:41 AM, Marek Polacek wrote: On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek wrote: On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: This fixe

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Marek Polacek
On Fri, Aug 21, 2015 at 03:37:38PM +0200, Richard Biener wrote: > On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek wrote: > > On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: > >> On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: > >> > This fixes the libgo breakage. Seems I re

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On Fri, Aug 21, 2015 at 2:49 PM, Marek Polacek wrote: > On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: >> On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: >> > This fixes the libgo breakage. Seems I really should have removed the >> > edge after we split the block with nul

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Marek Polacek
On Fri, Aug 21, 2015 at 01:27:43PM +0200, Richard Biener wrote: > On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: > > This fixes the libgo breakage. Seems I really should have removed the > > edge after we split the block with null dereference after __builtin_trap > > statement so that it'

Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Richard Biener
On Fri, Aug 21, 2015 at 12:52 PM, Marek Polacek wrote: > This fixes the libgo breakage. Seems I really should have removed the > edge after we split the block with null dereference after __builtin_trap > statement so that it's unreachable. > > Bootstrapped/regtested on x86_64-linux + ppc64-linux

[PATCH] Fix libgo breakage (PR tree-optimization/67284)

2015-08-21 Thread Marek Polacek
This fixes the libgo breakage. Seems I really should have removed the edge after we split the block with null dereference after __builtin_trap statement so that it's unreachable. Bootstrapped/regtested on x86_64-linux + ppc64-linux + bootstrapped on aarch64-linux, ok for trunk? 2015-08-21 Mare