Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-17 Thread Jeff Law
On 05/07/2013 09:05 AM, Julian Brown wrote: On Mon, 6 May 2013 11:53:20 -0600 I don't know. My assumption was that a "simple" mem would be one that the PRE pass could handle -- that clause was intended to handle simple mems in REG_EQUAL notes the same as simple mems as the source of a set. Maybe

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-15 Thread Julian Brown
On Tue, 7 May 2013 16:05:50 +0100 Julian Brown wrote: > On Mon, 6 May 2013 11:53:20 -0600 > Jeff Law wrote: > > > On 05/03/2013 07:10 AM, Julian Brown wrote: > > > Hi, > > > > > > This is a patch which fixes a latent bug in RTL GCSE/PRE, > > > described more fully in: > > > > > > http://gcc.gnu

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-07 Thread Julian Brown
On Mon, 6 May 2013 11:53:20 -0600 Jeff Law wrote: > On 05/03/2013 07:10 AM, Julian Brown wrote: > > Hi, > > > > This is a patch which fixes a latent bug in RTL GCSE/PRE, described > > more fully in: > > > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57159 > > > > I haven't been able to reproduce

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-06 Thread Jeff Law
On 05/03/2013 07:10 AM, Julian Brown wrote: Hi, This is a patch which fixes a latent bug in RTL GCSE/PRE, described more fully in: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57159 I haven't been able to reproduce the problem on mainline (nor on a supported target). Maybe someone more familiar

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-06 Thread Jeff Law
On 05/06/2013 10:27 AM, Steven Bosscher wrote: On Mon, May 6, 2013 at 5:28 PM, Jeff Law wrote: On 05/05/2013 04:18 AM, Steven Bosscher wrote: On Fri, May 3, 2013 at 3:10 PM, Julian Brown wrote: gcc/ * gcse.c (compute_ld_motion_mems): Invalidate non-simple mem refs in REG_EQ

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-06 Thread Steven Bosscher
On Mon, May 6, 2013 at 5:28 PM, Jeff Law wrote: > On 05/05/2013 04:18 AM, Steven Bosscher wrote: >> >> On Fri, May 3, 2013 at 3:10 PM, Julian Brown wrote: >>> >>> gcc/ >>> * gcse.c (compute_ld_motion_mems): Invalidate non-simple mem refs >>> in REG_EQUAL notes. >> >> >> Makes sense t

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-06 Thread Jeff Law
On 05/05/2013 04:18 AM, Steven Bosscher wrote: On Fri, May 3, 2013 at 3:10 PM, Julian Brown wrote: gcc/ * gcse.c (compute_ld_motion_mems): Invalidate non-simple mem refs in REG_EQUAL notes. Makes sense to me. Looking at REG_EQUAL notes in hash_scan_set is something relatively ne

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-05 Thread Steven Bosscher
On Fri, May 3, 2013 at 3:10 PM, Julian Brown wrote: > gcc/ > * gcse.c (compute_ld_motion_mems): Invalidate non-simple mem refs > in REG_EQUAL notes. Makes sense to me. Looking at REG_EQUAL notes in hash_scan_set is something relatively new. Your patch fixes something we appear to have

[PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-03 Thread Julian Brown
Hi, This is a patch which fixes a latent bug in RTL GCSE/PRE, described more fully in: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57159 I haven't been able to reproduce the problem on mainline (nor on a supported target). Maybe someone more familiar with the code in question than I am can tell