Re: [PATCH] Fix issue in uninit analysis (PR middle-end/61112)

2014-05-13 Thread Xinliang David Li
> > I think the right fix to the problem is to realize that BBs with the > following conditions y_8 !=0, p.0_10 !=0, and x_5 !=0 are actually > control equivalent. This fact allows simplifying the USE predicates > from (y_8 !=0 OR p.0_10 !=0 OR x_5 !=0) into just p.0_10 !=0 which is > the same as

Re: [PATCH] Fix issue in uninit analysis (PR middle-end/61112)

2014-05-13 Thread Xinliang David Li
I have concerns with the proposed this patch: 1) not sharing cd_root may lead to difficulties in later predication simplication 2) the change to check post-dom may also lead to incomplete predicate chain. I think the right fix to the problem is to realize that BBs with the following conditions y_

Re: [PATCH] Fix issue in uninit analysis (PR middle-end/61112)

2014-05-13 Thread Richard Biener
On Mon, May 12, 2014 at 5:42 AM, Patrick Palka wrote: > Hi, > > This patch fixes a bogus warning generated by -Wmaybe-uninitialized. > The problem is that we sometimes fail to acknowledge a defining edge > belonging to a control-dependence chain because we assume that each > defining edge shares t

[PATCH] Fix issue in uninit analysis (PR middle-end/61112)

2014-05-11 Thread Patrick Palka
Hi, This patch fixes a bogus warning generated by -Wmaybe-uninitialized. The problem is that we sometimes fail to acknowledge a defining edge belonging to a control-dependence chain because we assume that each defining edge shares the same control-dependence root. But this may not be true if a de