Re: [PATCH] Fix inlining checks wrt optimize attribute

2015-04-16 Thread Christian Bruel
On 01/22/2015 11:33 AM, Richard Biener wrote: > On Thu, 22 Jan 2015, Christian Bruel wrote: > >> Hi Richard, >> >> I thought one of my current issue would be solved by this patch, but it is >> not >> : I have some inlining failures with the attribute target on ARM. (e.g >> inline-3.c) where obvio

Re: [PATCH] Fix inlining checks wrt optimize attribute

2015-01-23 Thread Richard Biener
On Thu, 22 Jan 2015, Jan Hubicka wrote: > > > > As said in the other thread - this makes sure we don't perform inlining > > that might end up generating invalid code. It also preserves > > user-provided optimize attributes more properly. > > > > Bootstrapped and tested on x86_64-unknown-linux-g

Re: [PATCH] Fix inlining checks wrt optimize attribute

2015-01-22 Thread Jan Hubicka
> > As said in the other thread - this makes sure we don't perform inlining > that might end up generating invalid code. It also preserves > user-provided optimize attributes more properly. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. > > Richard. > > 2015-01-22

Re: [PATCH] Fix inlining checks wrt optimize attribute

2015-01-22 Thread Richard Biener
On Thu, 22 Jan 2015, Christian Bruel wrote: > Hi Richard, > > I thought one of my current issue would be solved by this patch, but it is not > : I have some inlining failures with the attribute target on ARM. (e.g > inline-3.c) where obvious early inline fails with because we fail into the > last

Re: [PATCH] Fix inlining checks wrt optimize attribute

2015-01-22 Thread Christian Bruel
Hi Richard, I thought one of my current issue would be solved by this patch, but it is not : I have some inlining failures with the attribute target on ARM. (e.g inline-3.c) where obvious early inline fails with because we fail into the last can_inline_edge_p case: opt_for_fn (callee->decl,

[PATCH] Fix inlining checks wrt optimize attribute

2015-01-22 Thread Richard Biener
As said in the other thread - this makes sure we don't perform inlining that might end up generating invalid code. It also preserves user-provided optimize attributes more properly. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2015-01-22 Richard Biener