Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-14 Thread Jeff Law
On 11/14/24 4:34 AM, Alex Coplan wrote: On 12/11/2024 10:56, Jeff Law wrote: On 11/12/24 4:46 AM, Alex Coplan wrote: Hi Alexey, On 12/11/2024 08:18, Alexey Merzlyakov wrote: gcc/ChangeLog: * simplify-rtx.cc (simplify_context::simplify_unary_operation_1): Fix subreg mode

Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-14 Thread Alex Coplan
On 12/11/2024 10:56, Jeff Law wrote: > > > On 11/12/24 4:46 AM, Alex Coplan wrote: > > Hi Alexey, > > > > On 12/11/2024 08:18, Alexey Merzlyakov wrote: > > > gcc/ChangeLog: > > > > > > * simplify-rtx.cc (simplify_context::simplify_unary_operation_1): > > > Fix subreg mode check during zero_

Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-12 Thread Jeff Law
On 11/12/24 11:31 AM, Alexey Merzlyakov wrote: Hi, Jeff, Oops... It looks like I've made a reply to Alex at the same time when you sent an e-mail update. It happens. But as Zdenek's test showed, we've got one more issue to resolve :-) Hopefully my email gave you a solid pointer on what nee

Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-12 Thread Andrew Pinski
On Tue, Nov 12, 2024 at 4:43 PM Jeff Law wrote: > > > > On 11/12/24 11:31 AM, Alexey Merzlyakov wrote: > > Hi, Jeff, > > > > Oops... It looks like I've made a reply to Alex at the same time when > > you sent an e-mail update. > > > > So, moving the testcase to the gcc.dg/torture directory. > > > >

Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-12 Thread Jeff Law
On 11/12/24 11:31 AM, Alexey Merzlyakov wrote: Hi, Jeff, Oops... It looks like I've made a reply to Alex at the same time when you sent an e-mail update. So, moving the testcase to the gcc.dg/torture directory. On Tue, Nov 12, 2024 at 10:56:13AM -0700, Jeff Law wrote: I think it might be b

Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-12 Thread Alexey Merzlyakov
Hi, Jeff, Oops... It looks like I've made a reply to Alex at the same time when you sent an e-mail update. So, moving the testcase to the gcc.dg/torture directory. On Tue, Nov 12, 2024 at 10:56:13AM -0700, Jeff Law wrote: > > I think it might be better to put the test in gcc.c-torture/execute, >

Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-12 Thread Alexey Merzlyakov
Hi, Alex, On Tue, Nov 12, 2024 at 11:46:54AM +, Alex Coplan wrote: > I think it might be better to put the test in gcc.c-torture/execute, > then it will automatically get run with the various torture options > and you should be able to drop both the dejagnu directives. > > Thanks, > Alex Yep.

Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-12 Thread Jeff Law
On 11/12/24 4:46 AM, Alex Coplan wrote: Hi Alexey, On 12/11/2024 08:18, Alexey Merzlyakov wrote: gcc/ChangeLog: * simplify-rtx.cc (simplify_context::simplify_unary_operation_1): Fix subreg mode check during zero_extend(not) -> xor optimization. gcc/testsuite/ChangeLog:

Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-12 Thread Alex Coplan
Hi Alexey, On 12/11/2024 08:18, Alexey Merzlyakov wrote: > gcc/ChangeLog: > > * simplify-rtx.cc (simplify_context::simplify_unary_operation_1): > Fix subreg mode check during zero_extend(not) -> xor optimization. > > gcc/testsuite/ChangeLog: > > * gcc.dg/pr117476.c: New test.

Re: [PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-12 Thread Alexey Merzlyakov
Updated testsuite/ChangeLog with respect to the original testcase author -- >8 -- gcc/ChangeLog: * simplify-rtx.cc (simplify_context::simplify_unary_operation_1): Fix subreg mode check during zero_extend(not) -> xor optimization. gcc/testsuite/ChangeLog: * gcc.dg/pr1174

[PATCH] Fix incorrect subreg mode check [PR117476]

2024-11-11 Thread Alexey Merzlyakov
gcc/ChangeLog: * simplify-rtx.cc (simplify_context::simplify_unary_operation_1): Fix subreg mode check during zero_extend(not) -> xor optimization. gcc/testsuite/ChangeLog: * gcc.dg/pr117476.c: New test. Signed-off-by: Alexey Merzlyakov --- gcc/simplify-rtx.cc