On Tue, Dec 7, 2021 at 12:10 PM Matthias Kretz wrote:
>
> On Tuesday, 7 December 2021 08:43:56 CET Richard Biener wrote:
> > On Mon, Dec 6, 2021 at 11:47 AM Matthias Kretz wrote:
> > > While reading the hash_map code I noticed this inconsistency. Bootstrapped
> > > and regtested on x86_64. OK for
On Tuesday, 7 December 2021 08:43:56 CET Richard Biener wrote:
> On Mon, Dec 6, 2021 at 11:47 AM Matthias Kretz wrote:
> > While reading the hash_map code I noticed this inconsistency. Bootstrapped
> > and regtested on x86_64. OK for trunk?
>
> I've inspected two users of said overload and they r
On Tue, Dec 7, 2021 at 9:38 AM Matthias Kretz wrote:
>
> On Tuesday, 7 December 2021 08:47:56 CET Richard Biener wrote:
> > On Tue, Dec 7, 2021 at 8:43 AM Richard Biener
> > wrote:
> >
> > >
> > >
> > > On Mon, Dec 6, 2021 at 11:47 AM Matthias Kretz wrote:
> > >
> > > >
> > > >
> > > > While rea
On Tuesday, 7 December 2021 08:47:56 CET Richard Biener wrote:
> On Tue, Dec 7, 2021 at 8:43 AM Richard Biener
> wrote:
>
> >
> >
> > On Mon, Dec 6, 2021 at 11:47 AM Matthias Kretz wrote:
> >
> > >
> > >
> > > While reading the hash_map code I noticed this inconsistency.
> > > Bootstrapped and
On Tue, Dec 7, 2021 at 8:43 AM Richard Biener
wrote:
>
> On Mon, Dec 6, 2021 at 11:47 AM Matthias Kretz wrote:
> >
> > While reading the hash_map code I noticed this inconsistency. Bootstrapped
> > and
> > regtested on x86_64. OK for trunk?
>
> I've inspected two users of said overload and they
On Mon, Dec 6, 2021 at 11:47 AM Matthias Kretz wrote:
>
> While reading the hash_map code I noticed this inconsistency. Bootstrapped and
> regtested on x86_64. OK for trunk?
I've inspected two users of said overload and they return true. Did you look
at the rest? I assume that bootstrapping and
While reading the hash_map code I noticed this inconsistency. Bootstrapped and
regtested on x86_64. OK for trunk?
The hash_map::traverse overload taking a non-const Value pointer breaks
if the callback returns false. The other overload should behave the
same.
Signed-off-by: Matthias Kretz
gcc