Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-16 Thread Jeff Law
On 10/15/2021 9:27 AM, Martin Liška wrote: On 10/14/21 16:27, Jeff Law wrote: So what's the preferred way to handle this?  We're in the process of evaluating -frename-registers on our target right now and subject to verification of a couple issues, our inclination is to turn it on for our t

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-15 Thread Martin Liška
On 10/14/21 16:27, Jeff Law wrote: So what's the preferred way to handle this?  We're in the process of evaluating -frename-registers on our target right now and subject to verification of a couple issues, our inclination is to turn it on for our target at -O2. Jeff I think the best approach

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-14 Thread Jeff Law via Gcc-patches
On 10/13/2021 4:02 AM, Martin Liška wrote: works and that it is not somehow dependent on ordering?  Otherwise we have to use EnabledBy(funroll-loops,funroll-all-loops) on frename-registers. I guess the EnabledBy doesn't work if the target decides to set flag_unroll_loop in one of its hook

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-13 Thread Richard Biener via Gcc-patches
On Wed, Oct 13, 2021 at 12:02 PM Martin Liška wrote: > > On 10/13/21 10:39, Richard Biener wrote: > > On Tue, Oct 12, 2021 at 5:11 PM Martin Liška wrote: > >> > >> On 10/12/21 15:37, Richard Biener wrote: > >>> by adding EnabledBy(funroll-loops) to the respective options instead > >>> (and funrol

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-13 Thread Martin Liška
On 10/13/21 10:39, Richard Biener wrote: On Tue, Oct 12, 2021 at 5:11 PM Martin Liška wrote: On 10/12/21 15:37, Richard Biener wrote: by adding EnabledBy(funroll-loops) to the respective options instead (and funroll-loops EnabledBy(funroll-all-loops)) All right, so the suggested approach wo

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-13 Thread Richard Biener via Gcc-patches
On Tue, Oct 12, 2021 at 5:11 PM Martin Liška wrote: > > On 10/12/21 15:37, Richard Biener wrote: > > by adding EnabledBy(funroll-loops) to the respective options instead > > (and funroll-loops EnabledBy(funroll-all-loops)) > > All right, so the suggested approach works correctly. > > Patch can boo

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-12 Thread Martin Liška
be installed? Thanks, MartinFrom c42efec30d7cce36c92d9369791826c9120dd3d1 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 12 Oct 2021 16:05:49 +0200 Subject: [PATCH] Fix handling of flag_rename_registers by a target. gcc/ChangeLog: * common.opt: Use EnabledBy instead of detection in

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-12 Thread Martin Liška
On 10/12/21 15:37, Richard Biener wrote: On Tue, Oct 12, 2021 at 2:18 PM Martin Liška wrote: Hello. The option is disabled in rs6000 target with: { OPT_LEVELS_ALL, OPT_frename_registers, NULL, 0 }, Thus, we have to do an auto-detection only if it's really unset and also equal to the I

Re: [PATCH] Fix handling of flag_rename_registers.

2021-10-12 Thread Richard Biener via Gcc-patches
On Tue, Oct 12, 2021 at 2:18 PM Martin Liška wrote: > > Hello. > > The option is disabled in rs6000 target with: > > { OPT_LEVELS_ALL, OPT_frename_registers, NULL, 0 }, > > Thus, we have to do an auto-detection only if it's really unset and also > equal to the Init value. > > Patch can bootst

[PATCH] Fix handling of flag_rename_registers.

2021-10-12 Thread Martin Liška
Hello. The option is disabled in rs6000 target with: { OPT_LEVELS_ALL, OPT_frename_registers, NULL, 0 }, Thus, we have to do an auto-detection only if it's really unset and also equal to the Init value. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. And the problema