Re: [PATCH] Fix gimple-ssa-sprintf.c caret related ICE (PR c/83448)

2017-12-21 Thread Jeff Law
On 12/21/2017 01:29 PM, Jakub Jelinek wrote: > Hi! > > If copying a substring without %s from the format string into the > destination does or might overflow, we try to point the caret at the > character in the format string that will cause the overflow. > In the first spot in maybe_warn this is o

Re: [PATCH] Fix gimple-ssa-sprintf.c caret related ICE (PR c/83448)

2017-12-21 Thread Martin Sebor
On 12/21/2017 01:29 PM, Jakub Jelinek wrote: Hi! If copying a substring without %s from the format string into the destination does or might overflow, we try to point the caret at the character in the format string that will cause the overflow. In the first spot in maybe_warn this is only done i

[PATCH] Fix gimple-ssa-sprintf.c caret related ICE (PR c/83448)

2017-12-21 Thread Jakub Jelinek
Hi! If copying a substring without %s from the format string into the destination does or might overflow, we try to point the caret at the character in the format string that will cause the overflow. In the first spot in maybe_warn this is only done if avail_range.min == avail_range.max and thus i