Re: [PATCH] Fix gimple-fold

2014-03-18 Thread Richard Biener
On Tue, Mar 18, 2014 at 3:59 PM, Martin Liška wrote: > Patch passes bootstrap and regtest. > > I fixed indentation according to discussion with Jakub. > > OK for trunk? Ok. Thanks, Richard. > Thanks, > Martin > > > On 03/18/2014 02:55 PM, Richard Biener wrote: >> >> On Tue, Mar 18, 2014 at 2:29

Re: [PATCH] Fix gimple-fold

2014-03-18 Thread Martin Liška
Patch passes bootstrap and regtest. I fixed indentation according to discussion with Jakub. OK for trunk? Thanks, Martin On 03/18/2014 02:55 PM, Richard Biener wrote: On Tue, Mar 18, 2014 at 2:29 PM, Martin Liška wrote: Thank you for feedback, Ok if it passes bootstrap / regtest. Thanks,

Re: [PATCH] Fix gimple-fold

2014-03-18 Thread Richard Biener
On Tue, Mar 18, 2014 at 2:29 PM, Martin Liška wrote: > Thank you for feedback, Ok if it passes bootstrap / regtest. Thanks, Richard. > new changelog: > > 2014-03-18 Martin Liska > > * cgraph.c (cgraph_update_edges_for_call_stmt_node): Added case when > gimple call statement i

Re: [PATCH] Fix gimple-fold

2014-03-18 Thread Martin Liška
Thank you for feedback, new changelog: 2014-03-18 Martin Liska * cgraph.c (cgraph_update_edges_for_call_stmt_node): Added case when gimple call statement is update. * gimple-fold.c (gimple_fold_call): Changed order for GIMPLE_ASSIGN and GIMPLE_CALL, where g

Re: [PATCH] Fix gimple-fold

2014-03-18 Thread Jakub Jelinek
Hi! > > 2014-03-18 Martin Liska > > > > * cgraph.c (cgraph_update_edges_for_call_stmt_node): added case when > > gimple call statement is updated. Capital letter after : > > * gimple-fold.c (gimple_fold_call): changed order for GIMPLE_ASSIGN > > and Likewise here.

Re: [PATCH] Fix gimple-fold

2014-03-18 Thread Richard Biener
On Tue, Mar 18, 2014 at 1:38 PM, Martin Liška wrote: > Hello, > I found ICE in Chromium compiled with LTO. There's a call that is proved > by ipa-devirt as __builtin_unreachable; same decision is done by gimple-fold > and this call is replaced by GIMPLE_CALL and GIMPLE_ASSIGN (in this order).

[PATCH] Fix gimple-fold

2014-03-18 Thread Martin Liška
Hello, I found ICE in Chromium compiled with LTO. There's a call that is proved by ipa-devirt as __builtin_unreachable; same decision is done by gimple-fold and this call is replaced by GIMPLE_CALL and GIMPLE_ASSIGN (in this order). After that condition for cgraph_update_edges_for_call_stm