Re: [PATCH] Fix for mklog

2014-11-11 Thread Diego Novillo
On 11/11/14 09:46, Marat Zakirov wrote: Attached patch make mklog to stop search for changes inside function once '}' occur. Ok, to commit? OK. Thanks. Diego.

[PATCH] Fix for mklog

2014-11-11 Thread Marat Zakirov
Hi all! I found another issue of mklog. Example: --- a/gcc/asan.h +++ b/gcc/asan.h @@ -103,4 +103,14 @@ asan_intercepted_p (enum built_in_function fcode) || fcode == BUILT_IN_STRNCMP || fcode == BUILT_IN_STRNCPY; } + +/* Convert LEN to HOST_WIDE_INT if possible. + Returns -

Re: [PATCH] Fix for mklog

2014-11-06 Thread Diego Novillo
On 11/06/14 03:00, Marat Zakirov wrote: Ok to commit? OK. Thanks. Diego.

Re: [PATCH] Fix for mklog

2014-11-06 Thread Yury Gribov
On 11/06/2014 12:07 PM, Yury Gribov wrote: On 11/06/2014 11:00 AM, Marat Zakirov wrote: -if ($doubtfunc) { -$idx = $line_idx; +$idx = $line_idx; # Skip line info in context diffs. -while ($is_context_diff && $diff_lines[$idx + 1] =~ /^[-\*]{3} [0-9]/) { -

Re: [PATCH] Fix for mklog

2014-11-06 Thread Yury Gribov
On 11/06/2014 11:00 AM, Marat Zakirov wrote: - if ($doubtfunc) { - $idx = $line_idx; + $idx = $line_idx; # Skip line info in context diffs. - while ($is_context_diff && $diff_lines[$idx + 1] =~ /^[-\*]{3} [0-9]/) { - ++$idx; -

[PATCH] Fix for mklog

2014-11-06 Thread Marat Zakirov
Hi all, Current mklog in some cases do not checks whether function have real changes or not. I fixed it by removing $doubtfunc and adding protection against EOF. Example: diff --git a/gcc/cfg.c b/gcc/cfg.c index 6070d9e..cb3dfd9 100644 --- a/gcc/cfg.c +++ b/gcc/cfg.c @@ -555,10 +555,10 @@ al