Re: [PATCH] Fix for PR ipa/64693

2015-02-27 Thread Jan Hubicka
> Hi. > > There's one missing vector comparison. Fix is obvious, ready for trunk? > > Thanks, > Martin > >From 3d03fb28ec21b6ed30d5179bd70aba79d246cd26 Mon Sep 17 00:00:00 2001 > From: mliska > Date: Fri, 27 Feb 2015 16:35:31 +0100 > Subject: [PATCH] Fix missing condition in symbol_compare_hash

Re: [PATCH] Fix for PR ipa/64693

2015-02-27 Thread Martin Liška
On 02/26/2015 07:21 PM, Jan Hubicka wrote: 2015-02-25 Martin Liska Jan Hubicka PR ipa/64693 * ipa-icf.c (symbol_compare_collection::symbol_compare_collection): New. (sem_item_optimizer::subdivide_classes_by_sensitive_refs): New function. (sem_item

Re: [PATCH] Fix for PR ipa/64693

2015-02-26 Thread Jan Hubicka
2015-02-25 Martin Liska Jan Hubicka PR ipa/64693 * ipa-icf.c (symbol_compare_collection::symbol_compare_collection): New. (sem_item_optimizer::subdivide_classes_by_sensitive_refs): New function. (sem_item_optimizer::process_cong_reduction): Include

Re: [PATCH] Fix for PR ipa/64693

2015-02-26 Thread Martin Liška
On 02/25/2015 07:46 PM, Jan Hubicka wrote: >From dd240028726cb7fdc777acd0b6d14c4f89aed714 Mon Sep 17 00:00:00 2001 From: mliska Date: Thu, 19 Feb 2015 16:08:09 +0100 Subject: [PATCH 1/3] Fix PR ipa/64693 2015-02-25 Martin Liska Jan Hubicka * gcc.dg/ipa/ipa-icf-26.c

Re: [PATCH] Fix for PR ipa/64693

2015-02-25 Thread Jan Hubicka
> > >From dd240028726cb7fdc777acd0b6d14c4f89aed714 Mon Sep 17 00:00:00 2001 > From: mliska > Date: Thu, 19 Feb 2015 16:08:09 +0100 > Subject: [PATCH 1/3] Fix PR ipa/64693 > > 2015-02-25 Martin Liska > Jan Hubicka > > * gcc.dg/ipa/ipa-icf-26.c: Update test. > * gcc.dg

Re: [PATCH] Fix for PR ipa/64693

2015-02-25 Thread Martin Liška
On 02/25/2015 06:00 PM, Jan Hubicka wrote: Hello Honza. I've updated the patch so that your notes are resolved. Moreover, I've added comparison for interposable symbols that are either target of reference or are called by a function. Please read the patch to verify the comparison is as you exp

Re: [PATCH] Fix for PR ipa/64693

2015-02-25 Thread Jan Hubicka
> Hello Honza. > > I've updated the patch so that your notes are resolved. Moreover, I've added > comparison > for interposable symbols that are either target of reference or are called by > a function. > Please read the patch to verify the comparison is as you expected. > > I'm going to run te

Re: [PATCH] Fix for PR ipa/64693

2015-02-25 Thread Martin Liška
On 02/20/2015 07:39 PM, Jan Hubicka wrote: Hello. There's updated version that reflects how should we handle congruence classes that have any address reference. Patch can bootstrap x86_64-linux-pc and no new regression is introduced? Ready for trunk? Thanks, Martin >From d7472e55b345214d

Re: [PATCH] Fix for PR ipa/64693

2015-02-20 Thread Jan Hubicka
> > Hi. > > This is second part which introduces better variable handling. Since readonly > variable flag > identification can identify new candidates, ICF should filter out > non-readonly variables in > execute phase. > > Ready for trunk? > Thanks, > Martin > >From a18a4840d14b1c0d35a9e4387d

Re: [PATCH] Fix for PR ipa/64693

2015-02-20 Thread Jan Hubicka
> Hello. > > There's updated version that reflects how should we handle congruence classes > that have any > address reference. Patch can bootstrap x86_64-linux-pc and no new regression > is introduced? > > Ready for trunk? > Thanks, > Martin > > > >From d7472e55b345214d55ed49f5f10deafa9a24a

Re: [PATCH] Fix for PR ipa/64693

2015-02-20 Thread Martin Liška
On 02/12/2015 05:57 PM, Jan Hubicka wrote: From: mliska V Date: Fri, 23 Jan 2015 14:58:36 +0100 Subject: [PATCH] Fix PR ipa/64693. gcc/ChangeLog: 2015-02-12 Martin Liska PR ipa/64693 * ipa-icf.c (sem_item_optimizer::execute): Call identify_address_sensitive_classes.

Re: [PATCH] Fix for PR ipa/64693

2015-02-20 Thread Martin Liška
On 02/12/2015 05:57 PM, Jan Hubicka wrote: From: mliska V Date: Fri, 23 Jan 2015 14:58:36 +0100 Subject: [PATCH] Fix PR ipa/64693. gcc/ChangeLog: 2015-02-12 Martin Liska PR ipa/64693 * ipa-icf.c (sem_item_optimizer::execute): Call identify_address_sensitive_classes.

Re: [PATCH] Fix for PR ipa/64693

2015-02-13 Thread Martin Liška
On 02/13/2015 02:37 PM, Martin Liška wrote: On 02/12/2015 05:57 PM, Jan Hubicka wrote: From: mliska V Date: Fri, 23 Jan 2015 14:58:36 +0100 Subject: [PATCH] Fix PR ipa/64693. gcc/ChangeLog: 2015-02-12 Martin Liska PR ipa/64693 * ipa-icf.c (sem_item_optimizer::execute): Call identi

Re: [PATCH] Fix for PR ipa/64693

2015-02-13 Thread Martin Liška
On 02/13/2015 02:37 PM, Martin Liška wrote: On 02/12/2015 05:57 PM, Jan Hubicka wrote: From: mliska V Date: Fri, 23 Jan 2015 14:58:36 +0100 Subject: [PATCH] Fix PR ipa/64693. gcc/ChangeLog: 2015-02-12 Martin Liska PR ipa/64693 * ipa-icf.c (sem_item_optimizer::execute): Call identi

Re: [PATCH] Fix for PR ipa/64693

2015-02-13 Thread Martin Liška
On 02/12/2015 05:57 PM, Jan Hubicka wrote: From: mliska V Date: Fri, 23 Jan 2015 14:58:36 +0100 Subject: [PATCH] Fix PR ipa/64693. gcc/ChangeLog: 2015-02-12 Martin Liska PR ipa/64693 * ipa-icf.c (sem_item_optimizer::execute): Call identify_address_sensitive_classes.

Re: [PATCH] Fix for PR ipa/64693

2015-02-12 Thread Jan Hubicka
> From: mliska V > Date: Fri, 23 Jan 2015 14:58:36 +0100 > Subject: [PATCH] Fix PR ipa/64693. > > gcc/ChangeLog: > > 2015-02-12 Martin Liska > > PR ipa/64693 > * ipa-icf.c (sem_item_optimizer::execute): Call > identify_address_sensitive_classes. > (sem_item_optimizer::ident

[PATCH] Fix for PR ipa/64693

2015-02-12 Thread Martin Liška
Hello. There's patch for aforementioned issue where ICF process a merge operation for a pair of functions that pass a pointer to the second pair of functions (these functions are also identical). Unfortunately, these addresses are compared for equality. Patch can lto-boostrap on x86_64 and pch.