Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-08 Thread Martin Liška
On 8/7/19 4:35 PM, Ian Lance Taylor wrote: > On Wed, Aug 7, 2019 at 5:09 AM Martin Liška wrote: >> >> There's one enhanced version where I added HAVE_FCNTL_H. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > > I think a better name than f

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-07 Thread Ian Lance Taylor
On Wed, Aug 7, 2019 at 5:09 AM Martin Liška wrote: > > There's one enhanced version where I added HAVE_FCNTL_H. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? I think a better name than fd_exists would be is_valid_fd. If that's OK with you,

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-07 Thread Pekka S
On 7.8.2019 15:09, Martin Liška wrote: Hi. There's one enhanced version where I added HAVE_FCNTL_H. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin Hi, tested this one against the latest trunk and it seems to be working -- as in

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-07 Thread Martin Liška
13:04:40 +0200 Subject: [PATCH] Fix file descriptor existence of MinGW. gcc/ChangeLog: 2019-08-07 Martin Liska PR bootstrap/91352 * gcc.c (driver::detect_jobserver): Use fd_exists. * lto-wrapper.c (jobserver_active_p): Likewise. include/ChangeLog: 2019-08-07 Martin Liska PR bootstr

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-07 Thread Martin Liška
for when F_GETFD isn't defined > e.g. through dup2 (fd, fd) < 0. Thank you for the review. I updated the patch accordingly. Martin > > And for the libiberty changes you want Ian to review them. > > Jakub > >From 7d3593a4189bd970ae752abab36c8a5bc4681847 M

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-07 Thread Jakub Jelinek
On Wed, Aug 07, 2019 at 10:45:08AM +0200, Martin Liška wrote: > @@ -155,3 +156,16 @@ lrealpath (const char *filename) >/* This system is a lost cause, just duplicate the filename. */ >return strdup (filename); > } > + > +/* Return true when FD file descriptor exists. */ > + > +int > +fd_

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-07 Thread Martin Liška
;>> 2019-08-06  Martin Liska  >>>> >>>>  PR bootstrap/91352 >>>>  * gcc.c (fd_exists): New. >>>>  (driver::detect_jobserver): Use fd_exists. >>>>  * lto-wrapper.c (fd_exists): New. >>>>  (jobserver_active_p): Use fd_exists. >>>

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-06 Thread Martin Sebor
On 8/6/19 9:55 AM, Martin Liška wrote: On 8/6/19 5:35 PM, Martin Sebor wrote: On 8/6/19 6:04 AM, Martin Liška wrote: Hi. The patch is about proper checking of file descriptors on Windows. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Is there a way to share the defi

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-06 Thread Martin Liška
On 8/6/19 5:35 PM, Martin Sebor wrote: > On 8/6/19 6:04 AM, Martin Liška wrote: >> Hi. >> >> The patch is about proper checking of file descriptors on Windows. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Is there a way to share the definition of the new functio

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-06 Thread Martin Sebor
On 8/6/19 6:04 AM, Martin Liška wrote: Hi. The patch is about proper checking of file descriptors on Windows. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Is there a way to share the definition of the new function so it doesn't have to be duplicated? Other than that

[PATCH] Fix file descriptor existence of MinGW.

2019-08-06 Thread Martin Liška
Hi. The patch is about proper checking of file descriptors on Windows. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. @Pekka: Can you please test it on Windows? Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-08-06 Martin Liska PR bootstrap/91352