Jeff Law writes:
> On 6/28/19 12:46 PM, Richard Sandiford wrote:
>> Segher Boessenkool writes:
>>> On Fri, Jun 28, 2019 at 08:55:00AM -0600, Martin Sebor wrote:
Jeff reminded me in a code review the other day that GCC does
have a guideline for defining POD structs with the keyword
On 6/28/19 12:46 PM, Richard Sandiford wrote:
> Segher Boessenkool writes:
>> On Fri, Jun 28, 2019 at 08:55:00AM -0600, Martin Sebor wrote:
>>> Jeff reminded me in a code review the other day that GCC does
>>> have a guideline for defining POD structs with the keyword
>>> "struct" and classes with
On 6/28/19 2:10 PM, Segher Boessenkool wrote:
On Fri, Jun 28, 2019 at 07:46:54PM +0100, Richard Sandiford wrote:
Segher Boessenkool writes:
On Fri, Jun 28, 2019 at 08:55:00AM -0600, Martin Sebor wrote:
Jeff reminded me in a code review the other day that GCC does
have a guideline for defining
On Fri, Jun 28, 2019 at 07:46:54PM +0100, Richard Sandiford wrote:
> Segher Boessenkool writes:
> > On Fri, Jun 28, 2019 at 08:55:00AM -0600, Martin Sebor wrote:
> >> Jeff reminded me in a code review the other day that GCC does
> >> have a guideline for defining POD structs with the keyword
> >>
Segher Boessenkool writes:
> On Fri, Jun 28, 2019 at 08:55:00AM -0600, Martin Sebor wrote:
>> Jeff reminded me in a code review the other day that GCC does
>> have a guideline for defining POD structs with the keyword
>> "struct" and classes with ctors/dtors using "class":
>>
>> https://gcc.gnu
On 6/28/19 10:59 AM, Jeff Law wrote:
On 6/28/19 8:55 AM, Martin Sebor wrote:
On 5/28/19 10:31 AM, Martin Sebor wrote:
On 5/28/19 4:24 AM, Martin Liška wrote:
On 5/28/19 11:31 AM, David CARLIER wrote:
Hi,
Here a tiny patch to fix few build warnings.
Kind regards.
Hi.
Well, I see a lot of
On 6/28/19 8:55 AM, Martin Sebor wrote:
> On 5/28/19 10:31 AM, Martin Sebor wrote:
>> On 5/28/19 4:24 AM, Martin Liška wrote:
>>> On 5/28/19 11:31 AM, David CARLIER wrote:
Hi,
Here a tiny patch to fix few build warnings.
Kind regards.
>>>
>>> Hi.
>>>
>>> Well, I see a
On Fri, Jun 28, 2019 at 08:55:00AM -0600, Martin Sebor wrote:
> Jeff reminded me in a code review the other day that GCC does
> have a guideline for defining POD structs with the keyword
> "struct" and classes with ctors/dtors using "class":
>
> https://gcc.gnu.org/codingconventions.html#Struct_
On 5/28/19 10:31 AM, Martin Sebor wrote:
On 5/28/19 4:24 AM, Martin Liška wrote:
On 5/28/19 11:31 AM, David CARLIER wrote:
Hi,
Here a tiny patch to fix few build warnings.
Kind regards.
Hi.
Well, I see a lot of these struct/class discrepancies when building
GCC with LLVM.
Question is wh
On Tue, May 28, 2019 at 10:28:07AM +, David CARLIER wrote:
> -- Forwarded message -
> From: David CARLIER
> Date: Tue, 28 May 2019 at 10:16
> Subject: Re: [PATCH] Fix few build warnings with LLVM toolchain
> To: Segher Boessenkool
>
>
> All right,
On Wed, May 29, 2019 at 12:53:44PM +0100, David CARLIER wrote:
> Here a little progress but maybe it s better doing this in small
> "batches" rather than fixing everything in one shot ?
IMHO if we want to do anything about this, we should just in
system.h add
#ifdef __clang__
#pragma clang diagnos
Here a little progress but maybe it s better doing this in small
"batches" rather than fixing everything in one shot ?
Kind regards.
Fixing few build warnings with clang/clang++ of this type:
../.././gcc/coretypes.h:76:1: warning: class 'rtx_def' was previously declared as a struct; this is valid,
On 5/28/19, Martin Sebor wrote:
> On 5/28/19 4:24 AM, Martin Liška wrote:
>> On 5/28/19 11:31 AM, David CARLIER wrote:
>>> Hi,
>>>
>>> Here a tiny patch to fix few build warnings.
>>>
>>> Kind regards.
>>>
>>
>> Hi.
>>
>> Well, I see a lot of these struct/class discrepancies when building GCC
>> w
On 5/28/19 4:24 AM, Martin Liška wrote:
On 5/28/19 11:31 AM, David CARLIER wrote:
Hi,
Here a tiny patch to fix few build warnings.
Kind regards.
Hi.
Well, I see a lot of these struct/class discrepancies when building GCC with
LLVM.
Question is whether it worth changing?
I think it's nic
Yes I sort of agree it is pretty harmless even though I cannot tell
for Microsoft toolchain issue here.
On Tue, 28 May 2019 at 10:27, Jakub Jelinek wrote:
>
> On Tue, May 28, 2019 at 12:24:12PM +0200, Martin Liška wrote:
> > Well, I see a lot of these struct/class discrepancies when building GCC
-- Forwarded message -
From: David CARLIER
Date: Tue, 28 May 2019 at 10:16
Subject: Re: [PATCH] Fix few build warnings with LLVM toolchain
To: Segher Boessenkool
All right, here an updated version, hope it looks better.
Thanks.
On Tue, 28 May 2019 at 10:09, Segher Boessenkool
On Tue, May 28, 2019 at 12:24:12PM +0200, Martin Liška wrote:
> Well, I see a lot of these struct/class discrepancies when building GCC with
> LLVM.
> Question is whether it worth changing?
No, the warning is just wrong. C++ clearly states what the struct and class
keyword mean and it is just fi
On 5/28/19 11:31 AM, David CARLIER wrote:
> Hi,
>
> Here a tiny patch to fix few build warnings.
>
> Kind regards.
>
Hi.
Well, I see a lot of these struct/class discrepancies when building GCC with
LLVM.
Question is whether it worth changing?
Martin
On Tue, May 28, 2019 at 09:31:18AM +, David CARLIER wrote:
> Here a tiny patch to fix few build warnings.
Please mention what the warning _is_, and why it is correct / why it is
a good idea to make these changes.
Segher
Hi,
Here a tiny patch to fix few build warnings.
Kind regards.
Index: gcc/ChangeLog
===
--- gcc/ChangeLog (revision 271684)
+++ gcc/ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2019-05-28 David Carlier
+
+* coretypes.h: Fix bu
20 matches
Mail list logo
