Re: [PATCH] Fix ctor reference folding (PR middle-end/65554)

2015-04-10 Thread Marek Polacek
On Fri, Apr 10, 2015 at 05:15:33PM -0700, H.J. Lu wrote: > On Fri, Apr 10, 2015 at 5:06 PM, H.J. Lu wrote: > > On Thu, Apr 9, 2015 at 11:28 AM, Marek Polacek wrote: > >> This test was failing at -O due to non-trivial conversion at assignment. > >> The reason is that gimple_fold_builtin_memory_op

Re: [PATCH] Fix ctor reference folding (PR middle-end/65554)

2015-04-10 Thread H.J. Lu
On Fri, Apr 10, 2015 at 5:06 PM, H.J. Lu wrote: > On Thu, Apr 9, 2015 at 11:28 AM, Marek Polacek wrote: >> This test was failing at -O due to non-trivial conversion at assignment. >> The reason is that gimple_fold_builtin_memory_op created invalid GIMPLE, >> because fold_ctor_reference called via

Re: [PATCH] Fix ctor reference folding (PR middle-end/65554)

2015-04-10 Thread H.J. Lu
On Thu, Apr 9, 2015 at 11:28 AM, Marek Polacek wrote: > This test was failing at -O due to non-trivial conversion at assignment. > The reason is that gimple_fold_builtin_memory_op created invalid GIMPLE, > because fold_ctor_reference called via fold_const_aggregate_ref was > discarding a cast, so

[PATCH] Fix ctor reference folding (PR middle-end/65554)

2015-04-09 Thread Marek Polacek
This test was failing at -O due to non-trivial conversion at assignment. The reason is that gimple_fold_builtin_memory_op created invalid GIMPLE, because fold_ctor_reference called via fold_const_aggregate_ref was discarding a cast, so it returned a different type than it got. Fixed by dropping us