Re: [PATCH] Fix condition in ira-color.c and lra-spills.c (PR c/61271)

2014-08-22 Thread Vladimir Makarov
On 2014-08-22 10:51 AM, Marek Polacek wrote: Bootstrapped/regtested on x86_64-linux, ok for trunk? Ok. Thanks, Marek. 2014-08-22 Marek Polacek PR c/61271 * ira-color.c (coalesced_pseudo_reg_slot_compare): Wrap LHS of a comparison in parens. * lra-spills.c

Re: [PATCH] Fix condition in ira-color.c and lra-spills.c (PR c/61271)

2014-08-22 Thread Marek Polacek
On Thu, Aug 21, 2014 at 03:38:25PM -0400, Vladimir Makarov wrote: > Sorry, Marek. I guess it is wrong. STACK_GROWS_DOWNWARD is only 0 or 1 > in these files (it is achieved by redefinition of STACK_GROWS_DOWNWARD > in the files). FAME_GROWS_DOWNWARD can be 0 or anything non-zero (even > non-const

Re: [PATCH] Fix condition in ira-color.c and lra-spills.c (PR c/61271)

2014-08-21 Thread Vladimir Makarov
On 08/21/2014 02:01 PM, Marek Polacek wrote: > Both ira-color.c and lra-spills.c contain this code, where > -Wlogical-not-parentheses would warn: > !FRAME_GROWS_DOWNWARD == STACK_GROWS_DOWNWARD > I think the condition is semantically right, so I just tweaked it > into a more common way with !=, so

[PATCH] Fix condition in ira-color.c and lra-spills.c (PR c/61271)

2014-08-21 Thread Marek Polacek
Both ira-color.c and lra-spills.c contain this code, where -Wlogical-not-parentheses would warn: !FRAME_GROWS_DOWNWARD == STACK_GROWS_DOWNWARD I think the condition is semantically right, so I just tweaked it into a more common way with !=, so we don't warn on this anymore. Bootstrapped/regtested