Re: [PATCH] Fix computed gotos on m68k

2011-11-01 Thread Eric Botcazou
> I've now committed the patch on 4.6 also. I did need to apply the > following patch from Bernd in order to test the 4.6 branch tip > successfully, since without it my build blew up in glibc with an error > in final.c: > > http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00454.html > > Maybe that pa

Re: [PATCH] Fix computed gotos on m68k

2011-11-01 Thread Julian Brown
On Fri, 28 Oct 2011 11:53:41 +0100 Julian Brown wrote: > On Tue, 25 Oct 2011 14:49:09 +0200 > Eric Botcazou wrote: > > > These labels are on the nonlocal_goto_handler_labels chain. You > > presumably just need to apply the same treatment to them in > > set_initial_label_offsets as the one appl

Re: [PATCH] Fix computed gotos on m68k

2011-10-28 Thread Julian Brown
On Tue, 25 Oct 2011 14:49:09 +0200 Eric Botcazou wrote: > These labels are on the nonlocal_goto_handler_labels chain. You > presumably just need to apply the same treatment to them in > set_initial_label_offsets as the one applied to forced labels. > OK for the adjusted patch if it works, mainl

Re: [PATCH] Fix computed gotos on m68k

2011-10-25 Thread Eric Botcazou
> This has been broken because since mainline revision r160124, which > (correctly) causes 'y' to be flagged as noreturn -- y never returns via > the normal function return route. If ipa-pure-const.c is hacked to > check that a function does not perform non-local gotos before marking > it noreturn,

Re: [PATCH] Fix computed gotos on m68k

2011-10-18 Thread Mikael Pettersson
Julian Brown writes: > Hi, > > This patch fixes computed gotos on m68k, and probably other targets too > (the fix is in the middle end). Several tests fail at present with "-O3 > -fomit-frame-pointer". This is the same bug as PR47918. As described in that PR trail, the bug can be triggered

[PATCH] Fix computed gotos on m68k

2011-10-18 Thread Julian Brown
Hi, This patch fixes computed gotos on m68k, and probably other targets too (the fix is in the middle end). Several tests fail at present with "-O3 -fomit-frame-pointer". One example of erroneous behaviour is as follows: the function 'x' in comp-goto-1.c compiles to: x: lea (-104,%sp),%s