Re: [PATCH] Fix checking of gimple types

2014-07-29 Thread Thomas Schwinge
Hi! On Wed, 23 Jul 2014 20:54:24 -0400, David Malcolm wrote: > On Wed, 2014-07-23 at 15:00 +0200, Thomas Schwinge wrote: > > In context of adding support for OpenACC, next to the existing > > GIMPLE_OMP_TARGET (quoting from gcc/gimple.def and gcc/gimple.h): > > > > DEFGSCODE(GIMPLE_OMP_TARGE

Re: [PATCH] Fix checking of gimple types

2014-07-23 Thread Thomas Schwinge
Hi! In context of adding support for OpenACC, next to the existing GIMPLE_OMP_TARGET (quoting from gcc/gimple.def and gcc/gimple.h): DEFGSCODE(GIMPLE_OMP_TARGET, "gimple_omp_target", GSS_OMP_PARALLEL_LAYOUT) /* GIMPLE_OMP_TARGET */ struct GTY((tag("GSS_OMP_PARALLEL_LAYOUT"))) g

Re: [PATCH] Fix checking of gimple types

2013-11-26 Thread David Malcolm
On Mon, 2013-11-25 at 12:34 -0700, Jeff Law wrote: > On 11/25/13 08:35, David Malcolm wrote: > > > > I'm not a fan of these "_layout" names, but I'm not sure what better to > > call them. Perhaps: > > GSS_OMP_PARALLEL_LAYOUT -> GSS_OMP_WITH_CLAUSES_CHILD_FN_DATA_ARG > > GSS_OMP_SINGLE_L

Re: [PATCH] Fix checking of gimple types

2013-11-25 Thread Jeff Law
On 11/25/13 08:35, David Malcolm wrote: I'm not a fan of these "_layout" names, but I'm not sure what better to call them. Perhaps: GSS_OMP_PARALLEL_LAYOUT -> GSS_OMP_WITH_CLAUSES_CHILD_FN_DATA_ARG GSS_OMP_SINGLE_LAYOUT -> GSS_OMP_WITH_CLAUSES GSS_OMP_ATOMIC_STORE_LAYOUT ->

Re: [PATCH] Fix checking of gimple types

2013-11-25 Thread Michael Matz
Hi, On Mon, 25 Nov 2013, David Malcolm wrote: > I'm not a fan of these "_layout" names, but I'm not sure what better to > call them. Perhaps: >GSS_OMP_PARALLEL_LAYOUT -> GSS_OMP_WITH_CLAUSES_CHILD_FN_DATA_ARG >GSS_OMP_SINGLE_LAYOUT -> GSS_OMP_WITH_CLAUSES >GSS_OMP_ATOMIC_STO

[PATCH] Fix checking of gimple types

2013-11-25 Thread David Malcolm
On Thu, 2013-11-21 at 18:03 -0500, Andrew MacLeod wrote: > On 11/21/2013 05:42 PM, Jakub Jelinek wrote: > > On Thu, Nov 21, 2013 at 03:24:55PM -0700, Jeff Law wrote: > >> On 11/21/13 15:19, Jakub Jelinek wrote: > >>> On Mon, Nov 18, 2013 at 03:25:52PM -0500, David Malcolm wrote: > > So is there