Re: [PATCH] Fix cgraph verification (PR middle-end/51929)

2012-02-17 Thread Jan Hubicka
> On Tue, Feb 14, 2012 at 11:12:31AM -0800, Jason Merrill wrote: > > On 02/10/2012 06:25 AM, Jakub Jelinek wrote: > > > PR middle-end/51929 > > > * cgraphunit.c (verify_edge_corresponds_to_fndecl): If node is > > > a same_body_alias, also test whether e->callee isn't a former > > > or curre

Re: [PATCH] Fix cgraph verification (PR middle-end/51929)

2012-02-14 Thread Jason Merrill
On 02/14/2012 11:49 AM, Jakub Jelinek wrote: Do we want a similar change to the use of former_clone_of in cgraph_update_edges_for_call_stmt_node? I don't think so. Then let's say the patch is OK tomorrow unless Jan objects today. Jason

Re: [PATCH] Fix cgraph verification (PR middle-end/51929)

2012-02-14 Thread Jakub Jelinek
On Tue, Feb 14, 2012 at 11:12:31AM -0800, Jason Merrill wrote: > On 02/10/2012 06:25 AM, Jakub Jelinek wrote: > > PR middle-end/51929 > > * cgraphunit.c (verify_edge_corresponds_to_fndecl): If node is > > a same_body_alias, also test whether e->callee isn't a former > > or current c

Re: [PATCH] Fix cgraph verification (PR middle-end/51929)

2012-02-14 Thread Jason Merrill
On 02/10/2012 06:25 AM, Jakub Jelinek wrote: PR middle-end/51929 * cgraphunit.c (verify_edge_corresponds_to_fndecl): If node is a same_body_alias, also test whether e->callee isn't a former or current clone of the decl this is a same body alias of. Do we want a s

[PATCH] Fix cgraph verification (PR middle-end/51929)

2012-02-10 Thread Jakub Jelinek
Hi! As discussed in the PR, this is a verification ICE if a call stmt calls a same_body_alias (__comp_ctor) and IPA-CP decides to clone the ctor, it clones the function with the body (__base_ctor), but before the call stmts are updated, the checking fails because the clone isn't clone or former cl