Re: [PATCH] Fix bug in MEM parsing in patches 8a/8b

2016-12-19 Thread David Malcolm
On Mon, 2016-12-19 at 15:10 -0700, Jeff Law wrote: > On 12/08/2016 01:39 PM, David Malcolm wrote: > > Testing the patch kit on i686 showed numerous failures of this > > assertion in set_mem_attributes_minus_bitpos in emit-rtl.c: > > > > 1821gcc_assert (!defattrs->offset_known_p); > > >

Re: [PATCH] Fix bug in MEM parsing in patches 8a/8b

2016-12-19 Thread Jeff Law
On 12/08/2016 01:39 PM, David Malcolm wrote: Testing the patch kit on i686 showed numerous failures of this assertion in set_mem_attributes_minus_bitpos in emit-rtl.c: 1821gcc_assert (!defattrs->offset_known_p); when expanding "main" in the rtl.exp test files, after parsing an __RTL-t

Re: [PATCH] Fix bug in MEM parsing in patches 8a/8b

2016-12-08 Thread Bernd Schmidt
On 12/08/2016 09:39 PM, David Malcolm wrote: OK as adjustments to patches 8a and 8b? Ok. Is it possible to adjust these macros to return something like a const reference to ensure people can't make this kind of error? Bernd

[PATCH] Fix bug in MEM parsing in patches 8a/8b

2016-12-08 Thread David Malcolm
Testing the patch kit on i686 showed numerous failures of this assertion in set_mem_attributes_minus_bitpos in emit-rtl.c: 1821gcc_assert (!defattrs->offset_known_p); when expanding "main" in the rtl.exp test files, after parsing an __RTL-tagged function. Root cause is various assignme