Re: [PATCH] Fix bad interaction between GTY((user)) and incomplete declarations

2013-08-16 Thread David Malcolm
On Fri, 2013-08-16 at 07:12 +0300, Laurynas Biveinis wrote: > > * gengtype.c (create_user_defined_type): Ensure that the kind > > is set to TYPE_USER_STRUCT, fixing a bug seen when an incomplete > > declaration is seen before the GTY((user)) marking. > > This is OK, thank y

Re: [PATCH] Fix bad interaction between GTY((user)) and incomplete declarations

2013-08-15 Thread Laurynas Biveinis
> * gengtype.c (create_user_defined_type): Ensure that the kind > is set to TYPE_USER_STRUCT, fixing a bug seen when an incomplete > declaration is seen before the GTY((user)) marking. This is OK, thank you. -- Laurynas

[PATCH] Fix bad interaction between GTY((user)) and incomplete declarations

2013-08-15 Thread David Malcolm
There is a bug in gengtype's handling of types marked with GTY((user)) which can lead to gtype-desc.c containing broken test-and-mark functions that fail to call the user-provided traversal functions, leading to segfaults. If the type is first encountered as an incomplete type declaration: str