Re: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-15 Thread Jeff Law via Gcc-patches
On 5/15/23 07:05, Thomas Neumann via Gcc-patches wrote: Hello, this patch breaks the build on targets where range is not declared i.e. where the #ifdef ATOMIC_FDE_FAST_PATH path is not taken. argh, I did not realize I tested the patch only on atomic fast path platforms. The patch below fixe

RE: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-15 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Thomas Neumann > Sent: Monday, May 15, 2023 2:06 PM > To: Kyrylo Tkachov ; Richard Biener > > Cc: Sören Tempel ; gcc-patches@gcc.gnu.org; > al...@ayaya.dev > Subject: Re: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

Re: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-15 Thread Thomas Neumann via Gcc-patches
Hello, this patch breaks the build on targets where range is not declared i.e. where the #ifdef ATOMIC_FDE_FAST_PATH path is not taken. argh, I did not realize I tested the patch only on atomic fast path platforms. The patch below fixes that by moving the check inside the #ifdef. I will chec

RE: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-15 Thread Kyrylo Tkachov via Gcc-patches
t; Subject: Re: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes > > On Sun, May 14, 2023 at 9:00 PM Thomas Neumann via Gcc-patches > wrote: > > > > Dear Sören, > > > > > we ran into a regression introduced by these changes. The regression > > >

Re: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-15 Thread Richard Biener via Gcc-patches
On Sun, May 14, 2023 at 9:00 PM Thomas Neumann via Gcc-patches wrote: > > Dear Sören, > > > we ran into a regression introduced by these changes. The regression > > manifests itself in a failing assertion in __deregister_frame_info_bases. > > The assertion failure was observed while using Chromium

Re: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-14 Thread alice via Gcc-patches
On Mon May 15, 2023 at 12:35 AM CEST, Thomas Neumann wrote: > > even building the flatbuffers repo externally using cmake at the same > > revision > > didn't reproduce it. > > > > that said, i have attached a dockerfile that shows you what /does/ fail, > > under > > the specific conditions. but

Re: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-14 Thread Thomas Neumann via Gcc-patches
even building the flatbuffers repo externally using cmake at the same revision didn't reproduce it. that said, i have attached a dockerfile that shows you what /does/ fail, under the specific conditions. but there is no unpatched libgcc_s, so you'll have to do that part yourself, and build a libg

Re: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-14 Thread alice via Gcc-patches
On Sun May 14, 2023 at 8:59 PM CEST, Thomas Neumann wrote: > Dear Sören, > > > we ran into a regression introduced by these changes. The regression > > manifests itself in a failing assertion in __deregister_frame_info_bases. > > The assertion failure was observed while using Chromium's `flatc` bui

Re: [PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-14 Thread Thomas Neumann via Gcc-patches
Dear Sören, we ran into a regression introduced by these changes. The regression manifests itself in a failing assertion in __deregister_frame_info_bases. The assertion failure was observed while using Chromium's `flatc` build system tool. The failing assertion is: unwind-dw2-fde.c:281

[PATCH] Fix assertion for unwind-dw2-fde.c btree changes

2023-05-14 Thread Sören Tempel via Gcc-patches
Dear Thomas Neumann, I am contacting you as the author of the commit with commit hash 6e80a1d164d1f996ad08a512c25a7c2ca893 [1] in the GCC repository. In this commit, you refactored the __register_frame/__deregister_frame implementation in GCC. The commit is part of the GCC 13 release. While up