Re: Patch ping (was Re: [PATCH] Fix aarch64_compare_and_swap* constraints (PR target/87839))

2018-11-21 Thread James Greenhalgh
On Tue, Nov 20, 2018 at 11:04:46AM -0600, Jakub Jelinek wrote: > Hi! > > On Tue, Nov 13, 2018 at 10:28:16AM +0100, Jakub Jelinek wrote: > > 2018-11-13 Jakub Jelinek > > > > PR target/87839 > > * config/aarch64/atomics.md (@aarch64_compare_and_swap): Use > > rIJ constraint for aarch

Patch ping (was Re: [PATCH] Fix aarch64_compare_and_swap* constraints (PR target/87839))

2018-11-20 Thread Jakub Jelinek
Hi! On Tue, Nov 13, 2018 at 10:28:16AM +0100, Jakub Jelinek wrote: > 2018-11-13 Jakub Jelinek > > PR target/87839 > * config/aarch64/atomics.md (@aarch64_compare_and_swap): Use > rIJ constraint for aarch64_plus_operand rather than rn. > > * gcc.target/aarch64/pr87839.c

Re: [PATCH] Fix aarch64_compare_and_swap* constraints (PR target/87839)

2018-11-18 Thread Richard Henderson
On 11/13/18 10:28 AM, Jakub Jelinek wrote: > - [(match_operand:GPI 2 "aarch64_plus_operand" "rn") ;; expect > + [(match_operand:GPI 2 "aarch64_plus_operand" "rIJ");; expect Ah, yes. That's my bug. There is a similar one just above wrt aarch64_compare_and_swap, and that one need

Re: [PATCH] Fix aarch64_compare_and_swap* constraints (PR target/87839)

2018-11-13 Thread Kyrill Tkachov
Hi Jakub, On 13/11/18 09:28, Jakub Jelinek wrote: Hi! The following testcase ICEs because the predicate and constraints on one of the operands of @aarch64_compare_and_swapdi aren't consistent. The RA which goes according to constraints (insn 15 13 16 2 (set (reg:DI 104) (const_int 8589

[PATCH] Fix aarch64_compare_and_swap* constraints (PR target/87839)

2018-11-13 Thread Jakub Jelinek
Hi! The following testcase ICEs because the predicate and constraints on one of the operands of @aarch64_compare_and_swapdi aren't consistent. The RA which goes according to constraints (insn 15 13 16 2 (set (reg:DI 104) (const_int 8589934595 [0x20003])) "pr87839.c":15:3 47 {*movdi_a