Re: [PATCH] Fix a bug that breaks go build

2012-09-21 Thread Dehao Chen
This patch was checked in as http://gcc.gnu.org/viewcvs?view=revision&revision=191614 I have another patch to add the new test. The new trunk can pass this test. If no objection, I'll check in this patch in an hour. Thanks, Dehao gcc/testsuite/ChangeLog: 2012-09-21 Dehao Chen PR go/5

Re: [PATCH] Fix a bug that breaks go build

2012-09-20 Thread Ian Lance Taylor
On Thu, Sep 20, 2012 at 7:31 PM, Dehao Chen wrote: > This patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54649 > > The previous patch is incorrect and will cause regression to > g++.dg/debug/dwarf2/deallocator.C > > A new patch is attached. It solved the bootstrap problem for go. > Basica

Re: [PATCH] Fix a bug that breaks go build

2012-09-20 Thread Dehao Chen
This patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54649 The previous patch is incorrect and will cause regression to g++.dg/debug/dwarf2/deallocator.C A new patch is attached. It solved the bootstrap problem for go. Basically, when we set the line number for stmts in the finally block,

[PATCH] Fix a bug that breaks go build

2012-09-20 Thread Dehao Chen
This patch fixes a bug is in tree-eh.c. IS_UNKNOWN_LOCATION is mistakenly used, thus the block info for a call stmt is cleared. Bootstrapped and gcc regression testing is on-going. Is it okay for trunk? Thanks, Dehao gcc/ChangeLog: tree-eh.c (lower_try_finally_dup_block): Use correct wa